1635273 - Make `FT_LCD_FILTER_H` a relative rather than absolute path

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

This helps get sccache hits across source directories.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1635273 - Make FT_LCD_FILTER_H a relative rather than absolute path. r?froydnj

This helps get sccache hits across source directories.

The previous presentation guaranteed the version of ftlcdfil.h in
the tree, while this unorthodox presentation only ensures that the
freetype2 directory has parent modules. This is at least unlikely
to occur in random /usr/include directories.

If this turns out to be an issue it would be possible to copy
ftlcdfil.h into the object directory, potentially with a unique
name, and then reference that (with a relative path).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nalexander, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #2)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nalexander, could you have a look please?
For more information, please visit auto_nag documentation.

I finally pushed a try build and relanded. The nag messages worked!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec18fc1e8fe0
Make FT_LCD_FILTER_H a relative rather than absolute path. r=froydnj

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/ec18fc1e8fe0