Closed Bug 1635306 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23393 - Add rAF delays before cross-origin clicks to fix flakiness.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23393 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23393
Details from upstream follow.

Mustaq Ahmed <mustaq@google.com> wrote:

Add rAF delays before cross-origin clicks to fix flakiness.

For cross-origin frames in WPTs, just waiting for all frames to load is
not enough because cross-origin frame's hit-test data may not be ready
by that time for the click to work correctly. This caused flakiness in
all three cross-origin tests for user-activation.

This CL adds rAF delays (after frame load completion) so that the clicks
can get through correctly.

Other changes: switched all async tests into sync tests nested inside a
single async test to make the code easier to follow.

Bug: 1064422, 1066178, 1066190
Change-Id: I853ff032c8050203abc72d89f0d6276af5102beb
Reviewed-on: https://chromium-review.googlesource.com/2174887
WPT-Export-Revision: 6524cfc90c3e7c4d87954d8ef359d00b7123ebcc

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 9 subtests

Status Summary

Firefox

TIMEOUT: 8
NOTRUN : 4

Chrome

OK : 2
PASS : 36
FAIL : 2
ERROR : 4

Safari

TIMEOUT: 8
NOTRUN : 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/user-activation/consumption-sameorigin.tentative.html: TIMEOUT (Chrome: ERROR, Safari: TIMEOUT)
Consumption test: NOTRUN (Chrome: PASS, Safari: NOTRUN)
/html/user-activation/consumption-crossorigin.sub.tentative.html: TIMEOUT (Chrome: ERROR, Safari: TIMEOUT)
Consumption test: NOTRUN (Chrome: PASS, Safari: NOTRUN)
/html/user-activation/navigation-state-reset-crossorigin.sub.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
Post-navigation state reset.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/html/user-activation/navigation-state-reset-sameorigin.tentative.html: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
Post-navigation state reset.: TIMEOUT (Chrome: FAIL, Safari: TIMEOUT)
/html/user-activation/propagation-crossorigin.sub.tentative.html: TIMEOUT (Chrome: ERROR, Safari: TIMEOUT)
Propagation test: NOTRUN (Chrome: PASS, Safari: NOTRUN)
/html/user-activation/propagation-sameorigin.tentative.html: TIMEOUT (Chrome: ERROR, Safari: TIMEOUT)
Propagation test: NOTRUN (Chrome: PASS, Safari: NOTRUN)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b16450fca68
[wpt PR 23393] - Add rAF delays before cross-origin clicks to fix flakiness., a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e180a7e97351
[wpt PR 23393] - Add rAF delays before cross-origin clicks to fix flakiness., a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.