Closed Bug 1635315 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 23394 - [Image Orientation] Fix canvas drawImage with a src rect subset

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23394 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23394
Details from upstream follow.

Stephen Chenney <schenney@chromium.org> wrote:

[Image Orientation] Fix canvas drawImage with a src rect subset

When converting the source rect for canvas drawImage with an
oriented image we must supply the uncropped image size as the
reference size for the correction method.

The test fails due to a lack of fuzzy matching in WPT. The result
is basiclaly correct.

Bug: 1074354
Change-Id: If9acd8c6ab7473cfa93018856aad059426584c3c
Reviewed-on: https://chromium-review.googlesource.com/2180863
WPT-Export-Revision: 1d104cd387b2b3a5808c0ebd404705ea2ddbe3d3

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central

Total 1 tests

Status Summary

Firefox

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-with-src-rect.tentative.html: FAIL

CI Results

Ran 11 Firefox configurations based on mozilla-central

Total 1 tests

Status Summary

Firefox

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-with-src-rect.tentative.html: FAIL

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ee704cc798a
[wpt PR 23394] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f706085bd35
[wpt PR 23394] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8f706085bd35

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.