Closed Bug 1635336 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23398 - Enabled setStartTime API for scroll animations

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23398 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23398
Details from upstream follow.

Olga Gerchikov <gerchiko@microsoft.com> wrote:

Enabled setStartTime API for scroll animations

  • Updated Animation::setStartTime to set animation outdated if start
    time changes from unresolved to resolved. This is to ensure animation
    is tracked by its timeline for future time updates.
  • Imported tests from [1] and updated to run for scroll animations. Some
    tests that use not enabled APIs are skipped and will be added as these
    APIs are enabled.
  • Added tests verifying setting current time when the timeline is
    inactive.

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/external/wpt/web-animations/timing-model/animations/setting-the-start-time-of-an-animation.html;l=1?originalUrl=https:%2F%2Fcs.chromium.org%2F
Bug: 916117
Change-Id: Ic03e84ad56cf8a538f0cf3d138d1e20067455dea

Reviewed-on: https://chromium-review.googlesource.com/2180509
WPT-Export-Revision: eae9927c426f7dccd541a868ecb977c4679e476c

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 5 subtests

Status Summary

Firefox

OK : 2
FAIL: 16

Chrome

OK : 2
PASS: 4
FAIL: 12

Safari

OK : 2
FAIL: 16

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-animations/setting-start-time.html
Setting the start time clears the hold time when the timeline is inactive: FAIL (Chrome: FAIL, Safari: FAIL)
Setting the start time on a running animation updates the play state: FAIL (Chrome: FAIL, Safari: FAIL)
Setting the start time resolves a pending ready promise: FAIL (Chrome: FAIL, Safari: FAIL)
Setting an unresolved start time on a play-pending animation makes it paused: FAIL (Chrome: FAIL, Safari: FAIL)
Setting an unresolved start time sets the hold time to unresolved when the timeline is inactive: FAIL (Chrome: FAIL, Safari: FAIL)
Setting the start time resolves a pending ready promise when the timelineis inactive: FAIL (Chrome: FAIL, Safari: FAIL)
Setting the start time clears the hold time: FAIL (Chrome: FAIL, Safari: FAIL)
Setting the start time on a reverse running animation updates the play state: FAIL (Chrome: FAIL, Safari: FAIL)
Setting an unresolved start time sets the hold time: FAIL (Chrome: FAIL, Safari: FAIL)
Setting the start time updates the finished state: FAIL (Chrome: FAIL, Safari: FAIL)
Setting an unresolved start time on a play-pending animation makes it idle when the timeline is inactive: FAIL (Chrome: FAIL, Safari: FAIL)
/scroll-animations/scroll-animation-inactive-timeline.html
Animation start and current times are correct if scroll timeline is activated after animation.play call.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct if scroll timeline is activated after setting start time.: FAIL (Chrome: FAIL, Safari: FAIL)
oncancel event is fired when the timeline is inactive.: FAIL (Chrome: PASS, Safari: FAIL)
Play pending task doesn't run when the timeline is inactive.: FAIL (Chrome: PASS, Safari: FAIL)
Animation current time is correct when the timeline becomes newly inactive and then active again.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f1c47233fd4 [wpt PR 23398] - Enabled setStartTime API for scroll animations, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3455a129c4e [wpt PR 23398] - Enabled setStartTime API for scroll animations, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.