Closed Bug 163541 Opened 18 years ago Closed 18 years ago

header.html.tmpl should set h1 be the empty string

Categories

(Bugzilla :: Bugzilla-General, defect)

2.17
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: myk, Assigned: myk)

Details

Attachments

(2 files)

header.html.tmpl currently doesn't let the primary page header (h1) be the empty
string, because the DEFAULT directive thinks "" == undefined and sets h1 = title
in that case.  This causes problems with, f.e. setting a title on the custom
b.m.o index page without that title appearing as the primary page header.

header.html.tmpl should let the calling template specify that h1 is empty.
This patch handles h1 outside the DEFAULT tag to avoid DEFAULT doing the wrong
thing.
This patch has been applied to b.m.o.
Is this behaviour as designed, or a bug? And if the latter, have we reported it?

Gerv
Comment on attachment 95916 [details] [diff] [review]
patch v1: fixes problem

looks reasonable

r=bbaetz x2
Attachment #95916 - Flags: review+
This is behavior as designed.

Checking in header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.16; previous revision: 1.15
done


Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Reopening.  Something strange is going on.  On my local install this patch works
fine, but on b.m.o. it makes primary headers stop appearing.  Changing the
conditional from the shortcut form to the classic form makes it work:

[% h1 = title IF !h1.defined %] --> [% IF !h1.defined %][% h1 = title %][% END %]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 95997 [details] [diff] [review]
patch v2: changes conditional structure

Really odd.

r=bbaetz x2
Attachment #95997 - Flags: review+
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v
 <--  header.html.tmpl
new revision: 1.17; previous revision: 1.16
done
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
(In reply to comment #3)
> Is this behaviour as designed, or a bug? And if the latter, have we reported
> it?
> 
> Gerv
> 

Was there ever a response to this? 

Assignee: justdave → myk
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.