Closed Bug 1635414 Opened 5 years ago Closed 5 years ago

ThreadUtils.IdleTaskRunner GTest may cause stack corruption

Categories

(Core :: XPCOM, defect)

defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Details

Attachments

(1 file)

Since the second runner in the test always returns false here: https://searchfox.org/mozilla-central/source/xpcom/tests/gtest/TestThreadUtils.cpp#783 it is essentially also repeating. However we fail to cancel it when the test ends. This may lead to it attempting to modify the stack variable after it goes out of scope.

Pushed by bschouten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e4dba7481174 Cancel second repeating runnable. r=smaug
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: