1635479 - [wpt-sync] Sync PR 23407 - Treat -webkit-writing-mode as animation-affecting

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23407 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23407
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

Treat -webkit-writing-mode as animation-affecting

Since writing-mode is an animation-affecting property, -webkit-
writing-mode must be as well, since it's a surrogate of writing-mode.

There's an underlying bug in the StyleCascade related to animation of
surrogates. For surrogates that are kHighPropertyPriority, the bug
causes a crash, because we're attempting to lookup a property that isn't
being animated. For other properties, it causes the surrogate to
silently not be applied.

Since -webkit-writing-mode is the only high-priority surrogate that
exists, making it disallowed in animations effectively makes the crash
unreachable.

I'll address the greater issue separately.

Bug: 1077501
Change-Id: I5df40337b88a1621ecbe20be04149ca2d6e9dfb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181209
Reviewed-by: Rune Lillesveen \<[e-mail]>
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#765523}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9666031db78fc07192e4cb413aa44dc408ed838c

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b49336c0021
[wpt PR 23407] - Treat -webkit-writing-mode as animation-affecting, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/473adc34a528
[wpt PR 23407] - Treat -webkit-writing-mode as animation-affecting, a=testonly

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/473adc34a528