[wpt-sync] Sync PR 23407 - Treat -webkit-writing-mode as animation-affecting
Categories
(Core :: CSS Transitions and Animations, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 23407 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/23407
Details from upstream follow.
Anders Hartvoll Ruud <andruud@chromium.org> wrote:
Treat -webkit-writing-mode as animation-affecting
Since writing-mode is an animation-affecting property, -webkit-
writing-mode must be as well, since it's a surrogate of writing-mode.There's an underlying bug in the StyleCascade related to animation of
surrogates. For surrogates that are kHighPropertyPriority, the bug
causes a crash, because we're attempting to lookup a property that isn't
being animated. For other properties, it causes the surrogate to
silently not be applied.Since -webkit-writing-mode is the only high-priority surrogate that
exists, making it disallowed in animations effectively makes the crash
unreachable.I'll address the greater issue separately.
Bug: 1077501
Change-Id: I5df40337b88a1621ecbe20be04149ca2d6e9dfb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181209
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765523}
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
PASS: 1
Safari
PASS: 1
Links
Comment 5•5 years ago
|
||
bugherder |
Description
•