Closed Bug 1635483 Opened 4 years ago Closed 4 years ago

Avoid making IPC calls on subrole calculations whenever possible.

Categories

(Core :: Disability Access APIs, defect, P1)

All
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: eeejay, Assigned: MarcoZ)

Details

(Whiteboard: [mac2020_1])

Attachments

(1 file)

We currently make at least one IPC call for each subrole retrieval. We call LandmarkRole() at the top, and if that does not return a landmark, which is the majority of cases, we call ARIARoleAtom() later on.

IPC calls should be avoided as much as possible, especially on generic getters like subrole.

Marco, can you take this bug? I think you have a good idea how to minimize IPC calls while keeping subrole functionality intact. For example, LandmarkRole() should probably only be called on objects that have a role of LANDMARK or REGION.

Flags: needinfo?(mzehe)

Yes I can take this and look into it.

Flags: needinfo?(mzehe)
Assignee: nobody → mzehe
Status: NEW → ASSIGNED
Pushed by mzehe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/52846e8cf092
Avoid unnecessary IPC calls when calculating subroles for landmarks, r=eeejay
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: