1635496 - dispatchMouseEvent test is broken

Status: RESOLVED FIXED

(Remote Protocol :: CDP, defect, P3)

Description

[Etienne Bruines]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4128.3 Safari/537.36

Steps to reproduce:

Regarding these tests:

https://searchfox.org/mozilla-central/source/remote/test/browser/input/browser_dispatchMouseEvent.js#40

Actual results:

The test succeeds regardless of the event actually firing, because this.mouseDownPromise is undefined.

await undefined works, it just resolves immediately with undefined

Expected results:

I'm guessing the mouseDownPromise should be saved under content and not this

Comment 1

[Etienne Bruines]

Attachment: Bug 1635496 - [remote] Fixed dispatchMouseEvent to not await undefined promises.

The "this" state is not persistent across spawn-calls, using "this" in
"function" also does not make a whole lot of sense.

In order to persist the Promise across spawn-calls, the value is stored
in "content" instead.

Since one cannot reliably return an Event from SpecialPowers.spawn (due
to serialization issues), we are awaiting them instead of returning.

Comment 2

[Etienne Bruines]

The actual problem can be reproduced by changing line 33, mousePressed into something like mouseReleased.

Without the fix, the test still passes. With the fix, the test fails as expected.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8d70ff72510
[remote] Fixed dispatchMouseEvent to not await undefined promises. r=remote-protocol-reviewers,whimboo

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c8d70ff72510