1635524 - pushsubscriptionchange event doesn't have oldSubscription/newSubscription (using ExtendableEvent instead of PushSubscriptionChangeEvent)

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, enhancement, P3)

Description

[glagh14]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4132.0 Safari/537.36

Steps to reproduce:

Question 1) I want to use event.oldSubscription and event.newSubscription in pushsubscriptionchange event. At least this is what w3c specs say and people about this. The way I triggered this event is simply by blocking and allowing notifications from mozilla's preference's notification's settings. i consoled.log event.oldSubscription and event.newSubscription

Question 2)

I have seen on the mozilla docs page, that the way it handles pushsubscriptionchange event is that in that event, it tries to subscribe again by using the event.oldSubscription. https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/pushsubscriptionchange_event .

Question: Is this the standard approach or would the last lines of code on the following website https://pushpad.xyz/service-worker.js be enough?

Actual results:

Question 1) oldSubscription and newSubscription are both undefined. Why? could this be because of the way I trigger it? and if mozilla itself triggers this, would they NOT be undefined at that stage?

Question 2) I'd appreciate the answer to the above I put in what did you do section

Expected results:

Question 1) oldSubscription and newSubscription shouldn't be undefined.

Question 2) I'd appreciate the answer to the above I put in what did you do section

Comment 1

[glagh14]

(In reply to glagh14 from comment #0)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4132.0 Safari/537.36

Steps to reproduce:

Question 1) I want to use event.oldSubscription and event.newSubscription in pushsubscriptionchange event. At least this is what w3c specs say and people about this. The way I triggered this event is simply by blocking and allowing notifications from mozilla's preference's notification's settings. i consoled.log event.oldSubscription and event.newSubscription

Question 2)

I have seen on the mozilla docs page, that the way it handles pushsubscriptionchange event is that in that event, it tries to subscribe again by using the event.oldSubscription. https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerGlobalScope/pushsubscriptionchange_event .

Question: Is this the standard approach or would the last lines of code on the following website https://pushpad.xyz/service-worker.js be enough?

Actual results:

Question 1) oldSubscription and newSubscription are both undefined. Why? could this be because of the way I trigger it? and if mozilla itself triggers this, would they NOT be undefined at that stage?

Question 2) I'd appreciate the answer to the above I put in what did you do section

Expected results:

Question 1) oldSubscription and newSubscription shouldn't be undefined.

Question 2) I'd appreciate the answer to the above I put in what did you do section

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1635524 - Part 1: Add PushSubscriptionChangeEvent interface r=asuth

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1635524 - Part 2: Pass oldSubscription for pushsubscriptionchange event r=asuth

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1ee5f4d9a42
Part 1: Add PushSubscriptionChangeEvent interface r=asuth
https://hg.mozilla.org/integration/autoland/rev/33887d137cbc
Part 2: Pass oldSubscription for pushsubscriptionchange event r=asuth
https://hg.mozilla.org/integration/autoland/rev/3a52c8a31e42
1943111: apply code formatting via Lando

Comment 6

[Atila Butkovits]

Backed out for causiung geckoview failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/1658e541c100c747e8119c5848cd739619a0fb5e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=3a52c8a31e42c242a31ac135f727ca5cdcba2fc2&selectedTaskRun=Kkw8PLPWQuSadT0E6tNjrA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=494064009&repo=autoland&lineNumber=23185

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60accb9c03d0
Part 1: Add PushSubscriptionChangeEvent interface r=asuth
https://hg.mozilla.org/integration/autoland/rev/9b6a7e93e074
Part 2: Pass oldSubscription for pushsubscriptionchange event r=asuth

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/60accb9c03d0
https://hg.mozilla.org/mozilla-central/rev/9b6a7e93e074