1635548 - Migrate browser-context.inc to Fluent, part 2

Status: RESOLVED FIXED

(Firefox :: General, task)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

After bug 1600528 landed, we still have 24 DTD entries in https://searchfox.org/mozilla-central/source/browser/base/content/browser-context.inc

Let's migrate them to Fluent.

Majority of the conversions should be fairly straightforward, barring two interesting areas that require solving:

1. There are pieces of code that use more complex attributes for actions, like:

      <menu id="fill-login"
            label="&fillLoginMenu.label;"
            label-login="&fillLoginMenu.label;"
            label-password="&fillPasswordMenu.label;"
            label-username="&fillUsernameMenu.label;"
            accesskey="&fillLoginMenu.accesskey;"
            accesskey-login="&fillLoginMenu.accesskey;"
            accesskey-password="&fillPasswordMenu.accesskey;"
            accesskey-username="&fillUsernameMenu.accesskey;"
            hidden="true">

This will likely cave in to Fluent quite nicely, but will require some JS code cleanups

2. There are bits used in moz-input-box.js widget

Those DTDs are reused here: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/moz-input-box.js#38-59

We'll need to update the code to inject FTL. The good news is that with bug 1627809 fixed, lazy injecting FTL should be now quite clean and reliable.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 3

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1635548 - Migrated browser-context.inc to Fluent. r?emalysz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d19ea5594d2
Migrated browser-context.inc to Fluent. r=emalysz,flod

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for assertion failures on ErrorResult.h

• backout: https://hg.mozilla.org/integration/autoland/rev/764f34e4fc7fc29cc3b7ff607007adb5216d87e4

• push: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=UHA_AldtQ6KI9gEG1xucNw.0&revision=4d19ea5594d208adc072a614115e285ea0d80cbc&group_state=expanded

• failure log: https://treeherder.mozilla.org/logviewer?job_id=349291653&repo=autoland&lineNumber=1611

[task 2021-08-23T19:14:21.464Z] 19:14:21     INFO - GECKO(1615) | Assertion failure: !IsDOMException() (Don't overwrite DOM exceptions), at /builds/worker/workspace/obj-build/dist/include/mozilla/ErrorResult.h:550
[task 2021-08-23T19:14:21.467Z] 19:14:21     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2021-08-23T19:14:32.705Z] 19:14:32     INFO - GECKO(1615) | #01: mozilla::binding_danger::TErrorResult<mozilla::binding_danger::AssertAndSuppressCleanupPolicy>::AssignErrorCode(nsresult) [dom/bindings/ErrorResult.h:550]
[task 2021-08-23T19:14:32.707Z] 19:14:32     INFO - GECKO(1615) | #02: mozilla::dom::DOMLocalization::ApplyTranslations(nsTArray<nsCOMPtr<mozilla::dom::Element> >&, nsTArray<mozilla::dom::Nullable<mozilla::dom::L10nMessage> >&, nsXULPrototypeDocument*, mozilla::ErrorResult&) [dom/l10n/DOMLocalization.cpp:474]
[task 2021-08-23T19:14:32.708Z] 19:14:32     INFO - GECKO(1615) | #03: mozilla::dom::DOMLocalization::TranslateElements(mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::dom::Element> > const&, nsXULPrototypeDocument*, mozilla::ErrorResult&) [dom/l10n/DOMLocalization.cpp:348]
[task 2021-08-23T19:14:32.708Z] 19:14:32     INFO - GECKO(1615) | #04: mozilla::dom::DocumentL10n::TranslateDocument(mozilla::ErrorResult&) [dom/l10n/DocumentL10n.cpp:201]
[task 2021-08-23T19:14:32.709Z] 19:14:32     INFO - GECKO(1615) | #05: mozilla::dom::DocumentL10n::TriggerInitialTranslation() [dom/l10n/DocumentL10n.cpp:107]
[task 2021-08-23T19:14:32.709Z] 19:14:32     INFO - GECKO(1615) | #06: mozilla::dom::PrototypeDocumentContentSink::MaybeDoneWalking() [dom/prototype/PrototypeDocumentContentSink.cpp:639]
[task 2021-08-23T19:14:32.710Z] 19:14:32     INFO - GECKO(1615) | #07: {virtual override thunk({offset(-16)}, mozilla::dom::PrototypeDocumentContentSink::StyleSheetLoaded(mozilla::StyleSheet*, bool, nsresult))} [/opt/worker/tasks/task_162974533740585/build/application/Firefox NightlyDebug.app/Contents/MacOS/XUL + 0x3bb782e]
[task 2021-08-23T19:14:32.711Z] 19:14:32     INFO - GECKO(1615) | #08: mozilla::css::Loader::NotifyObservers(mozilla::css::SheetLoadData&, nsresult) [layout/style/Loader.cpp:1570]
[task 2021-08-23T19:14:32.711Z] 19:14:32     INFO - GECKO(1615) | #09: mozilla::SharedStyleSheetCache::LoadCompleted(mozilla::SharedStyleSheetCache*, mozilla::css::SheetLoadData&, nsresult) [layout/style/SharedStyleSheetCache.cpp:336]
[task 2021-08-23T19:14:32.713Z] 19:14:32     INFO - GECKO(1615) | #10: mozilla::MozPromise<bool, bool, true>::ThenValue<mozilla::css::Loader::ParseSheet(nsTSubstring<char> const&, mozilla::css::SheetLoadData&, mozilla::css::Loader::AllowAsyncParse)::$_0, mozilla::css::Loader::ParseSheet(nsTSubstring<char> const&, mozilla::css::SheetLoadData&, mozilla::css::Loader::AllowAsyncParse)::$_1>::DoResolveOrRejectInternal(mozilla::MozPromise<bool, bool, true>::ResolveOrRejectValue&) [xpcom/threads/MozPromise.h:859]
[task 2021-08-23T19:14:32.713Z] 19:14:32     INFO - GECKO(1615) | #11: mozilla::MozPromise<bool, bool, true>::ThenValueBase::ResolveOrRejectRunnable::Run() [xpcom/threads/MozPromise.h:488]
[task 2021-08-23T19:14:32.714Z] 19:14:32     INFO - GECKO(1615) | #12: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:503]
[task 2021-08-23T19:14:32.714Z] 19:14:32     INFO - GECKO(1615) | #13: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:805]
[task 2021-08-23T19:14:32.715Z] 19:14:32     INFO - GECKO(1615) | #14: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:641]
[task 2021-08-23T19:14:32.716Z] 19:14:32     INFO - GECKO(1615) | #15: mozilla::TaskController::ProcessPendingMTTask(bool) [xpcom/threads/TaskController.cpp:425]
[task 2021-08-23T19:14:32.716Z] 19:14:32     INFO - GECKO(1615) | #16: mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_0>::Run() [xpcom/threads/nsThreadUtils.h:533]
[task 2021-08-23T19:14:32.717Z] 19:14:32     INFO - GECKO(1615) | #17: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1152]
[task 2021-08-23T19:14:32.717Z] 19:14:32     INFO - GECKO(1615) | #18: NS_ProcessPendingEvents(nsIThread*, unsigned int) [xpcom/threads/nsThreadUtils.cpp:431]
[task 2021-08-23T19:14:32.718Z] 19:14:32     INFO - GECKO(1615) | #19: nsBaseAppShell::NativeEventCallback() [widget/nsBaseAppShell.cpp:88]
[task 2021-08-23T19:14:32.718Z] 19:14:32     INFO - GECKO(1615) | #20: nsAppShell::ProcessGeckoEvents(void*) [widget/cocoa/nsAppShell.mm:476]
[task 2021-08-23T19:14:32.767Z] 19:14:32     INFO - GECKO(1615) | #21: __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation + 0x83d52]
[task 2021-08-23T19:14:32.767Z] 19:14:32     INFO - GECKO(1615) | #22: __CFRunLoopDoSource0 [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation + 0x83cf1]
[task 2021-08-23T19:14:32.768Z] 19:14:32     INFO - GECKO(1615) | #23: __CFRunLoopDoSources0 [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation + 0x83b0b]
[task 2021-08-23T19:14:32.769Z] 19:14:32     INFO - GECKO(1615) | #24: __CFRunLoopRun [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation + 0x8283a]
[task 2021-08-23T19:14:32.769Z] 19:14:32     INFO - GECKO(1615) | #25: CFRunLoopRunSpecific [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation + 0x81e3e]
[task 2021-08-23T19:14:32.789Z] 19:14:32     INFO - GECKO(1615) | #26: RunCurrentEventLoopInMode [/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox + 0x2fabd]
[task 2021-08-23T19:14:32.789Z] 19:14:32     INFO - GECKO(1615) | #27: ReceiveNextEventCommon [/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox + 0x2f7d5]
[task 2021-08-23T19:14:32.790Z] 19:14:32     INFO - GECKO(1615) | #28: _BlockUntilNextEventMatchingListInModeWithFilter [/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox + 0x2f579]
[task 2021-08-23T19:14:32.889Z] 19:14:32     INFO - GECKO(1615) | #29: _DPSNextEvent [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit + 0x41039]
[task 2021-08-23T19:14:32.890Z] 19:14:32     INFO - GECKO(1615) | #30: -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit + 0x3f880]
[task 2021-08-23T19:14:32.890Z] 19:14:32     INFO - GECKO(1615) | #31: -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] [widget/cocoa/nsAppShell.mm:173]
[task 2021-08-23T19:14:32.891Z] 19:14:32     INFO - GECKO(1615) | #32: -[NSApplication run] [/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit + 0x3158e]
[task 2021-08-23T19:14:32.891Z] 19:14:32     INFO - GECKO(1615) | #33: nsAppShell::Run() [widget/cocoa/nsAppShell.mm:748]
[task 2021-08-23T19:14:32.892Z] 19:14:32     INFO - GECKO(1615) | #34: nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:285]
[task 2021-08-23T19:14:32.892Z] 19:14:32     INFO - GECKO(1615) | #35: XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:5283]
[task 2021-08-23T19:14:32.893Z] 19:14:32     INFO - GECKO(1615) | #36: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5475]
[task 2021-08-23T19:14:32.893Z] 19:14:32     INFO - GECKO(1615) | #37: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:5534]
[task 2021-08-23T19:14:32.894Z] 19:14:32     INFO - GECKO(1615) | #38: main [browser/app/nsBrowserApp.cpp:378]
[task 2021-08-23T19:17:20.013Z] 19:17:20     INFO - runtests.py | Waiting for browser...
[task 2021-08-23T19:17:20.013Z] 19:17:20     INFO - TEST-INFO | Main app process: exit 1
[task 2021-08-23T19:17:20.014Z] 19:17:20     INFO - Buffered messages finished
[task 2021-08-23T19:17:20.014Z] 19:17:20    ERROR - TEST-UNEXPECTED-FAIL | automation.py | application terminated with exit code 1
[task 2021-08-23T19:17:20.014Z] 19:17:20     INFO - runtests.py | Application ran for: 0:03:00.114322
[task 2021-08-23T19:17:20.015Z] 19:17:20     INFO - zombiecheck | Reading PID log: /var/folders/43/c9bry4g56k73rnnfp2c72w5h000014/T/tmp_9vvghwopidlog
[task 2021-08-23T19:17:20.015Z] 19:17:20     INFO - mozcrash Copy/paste: /opt/worker/tasks/task_162974533740585/fetches/minidump_stackwalk/minidump_stackwalk /var/folders/43/c9bry4g56k73rnnfp2c72w5h000014/T/tmprn1_a7ac.mozrunner/minidumps/D73961B3-4C3F-444D-8799-14BAE0B33330.dmp /opt/worker/tasks/task_162974533740585/build/symbols
[task 2021-08-23T19:17:26.194Z] 19:17:26     INFO - mozcrash Saved minidump as /opt/worker/tasks/task_162974533740585/build/blobber_upload_dir/D73961B3-4C3F-444D-8799-14BAE0B33330.dmp
[task 2021-08-23T19:17:26.194Z] 19:17:26     INFO - mozcrash Saved app info as /opt/worker/tasks/task_162974533740585/build/blobber_upload_dir/D73961B3-4C3F-444D-8799-14BAE0B33330.extra
[task 2021-08-23T19:17:26.532Z] 19:17:26     INFO - PROCESS-CRASH | automation.py | application crashed [@ mozilla::dom::DOMLocalization::ApplyTranslations(nsTArray<nsCOMPtr<mozilla::dom::Element> >&, nsTArray<mozilla::dom::Nullable<mozilla::dom::L10nMessage> >&, nsXULPrototypeDocument*, mozilla::ErrorResult&)]

Comment 6

[Natalia Csoregi [:nataliaCs]]

other failures:

• TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::binding_danger::TErrorResult, ThrowInvalidStateError, MaybeReportErrorsToGecko, mozilla::intl::Localization::FormatMessagesSync
• multiple tests failing with: uncaught exception - TypeError: can't access property "replace", docElement.dataset[("contentTitle" + dataSuffix)] is undefined at getWindowTitleForBrowser@chrome://browser/content/tabbrowser.js

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/fcb61f75037a