Closed Bug 1635593 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23409 - Fix testharness.js's assert_object_equals error message

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox78 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23409 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23409
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

Fix testharness.js's assert_object_equals error message

When using assert_object_equals, if the two objects have the same
property but with different values, then the error message used to say
that the actual and expected values of the property were the root
objects themselves.

This patch fixes it so that the error message references the actual and
expected value of the property.

Change-Id: If9e6a5445db13444e22fd58729614c8c73046aea
Reviewed-on: https://chromium-review.googlesource.com/2181322
WPT-Export-Revision: 4688fcac39ebcf68db4730e8984651eff90e1136

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c8c1aae1c9b [wpt PR 23409] - Fix testharness.js's assert_object_equals error message, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1224006b0542 [wpt PR 23409] - Fix testharness.js's assert_object_equals error message, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/1224006b0542

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.