1635614 - DO NOT CLASSIFY StashError: Tried to overwrite existing shared stash value for key ('/fetch/metadata/resources/record-header.py', '137b9c5b-5da2-a627-9ca4-d4fcb2d3a15c')

Status: RESOLVED INCOMPLETE

(Core :: DOM: Networking, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=300945625&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/RUUfUcUlSXWNGRBPm_NSwQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-05-05T23:00:14.177Z] 23:00:14 INFO - TEST-START | /fetch/metadata/preload.https.sub.html
[task 2020-05-05T23:00:14.183Z] 23:00:14 INFO - Closing window 61
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING - Traceback (most recent call last):
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 332, in call
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING - rv = self.func(request, response)
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/tests/web-platform/tests/fetch/metadata/resources/record-header.py", line 42, in main
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING - request.server.stash.put(testId, header)
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/venv/lib/python2.7/site-packages/wptserve/stash.py", line 165, in put
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING - (internal_key, self.data[internal_key], value))
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING - StashError: Tried to overwrite existing shared stash value for key ('/fetch/metadata/resources/record-header.py', '137b9c5b-5da2-a627-9ca4-d4fcb2d3a15c') (old value was {"dest": "empty", "user": "", "mode": "cors", "site": "same-origin"}, new value is {"dest": "empty", "user": "", "mode": "cors", "site": "same-site"})
[task 2020-05-05T23:00:14.624Z] 23:00:14 WARNING -
[task 2020-05-05T23:00:14.649Z] 23:00:14 WARNING - Traceback (most recent call last):
[task 2020-05-05T23:00:14.649Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 332, in call
[task 2020-05-05T23:00:14.649Z] 23:00:14 WARNING - rv = self.func(request, response)
[task 2020-05-05T23:00:14.649Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/tests/web-platform/tests/fetch/metadata/resources/record-header.py", line 42, in main
[task 2020-05-05T23:00:14.649Z] 23:00:14 WARNING - request.server.stash.put(testId, header)
[task 2020-05-05T23:00:14.650Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/venv/lib/python2.7/site-packages/wptserve/stash.py", line 165, in put
[task 2020-05-05T23:00:14.650Z] 23:00:14 WARNING - (internal_key, self.data[internal_key], value))
[task 2020-05-05T23:00:14.650Z] 23:00:14 WARNING - StashError: Tried to overwrite existing shared stash value for key ('/fetch/metadata/resources/record-header.py', '137b9c5b-5da2-a627-9ca4-d4fcb2d3a15c') (old value was {"dest": "empty", "user": "", "mode": "cors", "site": "same-origin"}, new value is {"dest": "empty", "user": "", "mode": "cors", "site": "cross-site"})
[task 2020-05-05T23:00:14.650Z] 23:00:14 WARNING -
[task 2020-05-05T23:00:14.658Z] 23:00:14 WARNING - Traceback (most recent call last):
[task 2020-05-05T23:00:14.659Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/venv/lib/python2.7/site-packages/wptserve/handlers.py", line 332, in call
[task 2020-05-05T23:00:14.659Z] 23:00:14 WARNING - rv = self.func(request, response)
[task 2020-05-05T23:00:14.659Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/tests/web-platform/tests/fetch/metadata/resources/record-header.py", line 42, in main
[task 2020-05-05T23:00:14.659Z] 23:00:14 WARNING - request.server.stash.put(testId, header)
[task 2020-05-05T23:00:14.659Z] 23:00:14 WARNING - File "/Users/cltbld/tasks/task_1588717718/build/venv/lib/python2.7/site-packages/wptserve/stash.py", line 165, in put
[task 2020-05-05T23:00:14.659Z] 23:00:14 WARNING - (internal_key, self.data[internal_key], value))
[task 2020-05-05T23:00:14.659Z] 23:00:14 WARNING - StashError: Tried to overwrite existing shared stash value for key ('/fetch/metadata/resources/record-header.py', 'ab8755e2-e7a3-914a-55ae-14e836cf1fee') (old value was {"dest": "font", "user": "", "mode": "cors", "site": "same-origin"}, new value is {"dest": "font", "user": "", "mode": "cors", "site": "same-site"})
[task 2020-05-05T23:00:14.659Z] 23:00:14 WARNING -

Noticed these lines appear before the actual failure is shown, and it's also present on passed tests e.g. :
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=de01960b53b6fbac158d05c9a2bb74694e3221dc&searchStr=OS%2CX%2C10.14%2CShippable%2Copt%2CWeb%2Cplatform%2Ctests%2Ctest-macosx1014-64-shippable%2Fopt-web-platform-tests-e10s-8%2CW%28wpt8%29&selectedTaskRun=X1ZMhwYFRfqXVVPzzYfmwg-0 with log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=300941589&repo=autoland&lineNumber=3184

James, is this something you can look into since it only appears on web platform tests?
Thank you.

Comment 1

[James Graham [:jgraham]]

This suggests a bug in the tests. Let's see if Mike West will take a look. Otherwise I can have another look.

Comment 2

[Mike West]

Hey James. The test in question should be pulling a new stash key for each subtest (https://github.com/web-platform-tests/wpt/blob/25f5eba2c3493e37f653bfecd6c5d43679b1a2bb/fetch/metadata/preload.https.sub.html#L15). Have I misunderstood how {{uuid()}} works? Should we be adding additional entropy to that generated key?

Comment 3

[James Graham [:jgraham]]

Ah yeah, that won't work. uuid() there is generated when the page is loaded on the server, not in js. If you want a UUID at runtime use https://searchfox.org/mozilla-central/source/testing/web-platform/tests/common/utils.js#67

Comment 4

[Mike West]

Ah. Yes. That is fantastically stupid on my part, especially since I didn't see it again when I looked upthread.

https://github.com/web-platform-tests/wpt/pull/23431

Comment 5

[Intermittent Failures Robot]

3 failures in 5276 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2
• mozilla-central: 1

Platform breakdown:

• linux1804-64-shippable: 2
• linux1804-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1635614&startday=2020-05-04&endday=2020-05-10&tree=all

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 7

[Intermittent Failures Robot]

1 failures in 5488 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• linux1804-32-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1635614&startday=2020-05-11&endday=2020-05-17&tree=all

Comment 8

[Intermittent Failures Robot]

8 failures in 4727 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 8

Platform breakdown:

• linux1804-64-qr: 4
• linux1804-64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1635614&startday=2020-05-18&endday=2020-05-24&tree=all

Comment 9

[Jens Stutte [:jstutte]]

Bulk closing some old intermittents.