1635671 - error[E0428]: the name `U1024` is defined multiple times

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

When building in some configurations of rustc (e.g. i386 without SSE), building Firefox fails with, among other things:

error[E0428]: the name `U1024` is defined multiple times

This comes from the typenum library. The issue was fixed in https://github.com/paholg/typenum/commit/14a3322d1081fd63d5eb44bf8ab8f90676208228, so all it takes is an upgrade of the crate.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1635671 - Upgrade typename to 1.12.0.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3ed3710adce
Upgrade typename to 1.12.0. r=emilio

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 9146065 [details]
Bug 1635671 - Upgrade typename to 1.12.0.

Beta/Release Uplift Approval Request

• User impact if declined: Build failure in some configurations
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a rust crate that doesn't actually provide code that does something, rather type helpers to deal with things like sizes at compile time.
• String changes made/needed:

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9146065 [details]
Bug 1635671 - Upgrade typename to 1.12.0.

uplift approved for 77.0b3, thanks.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f3ed3710adce

Comment 6

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7bdae2416d6c