Closed Bug 1635673 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23412 - [ResourceTiming] Dispatch entry for 404 scripts

Categories

(Core :: Performance, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23412 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23412
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

[ResourceTiming] Dispatch entry for 404 scripts

This CL fixes dispatching PerformanceResourceTiming entries when the
resource was a 404 script. These do not go through HandleLoaderFinish()
and instead go through HandleLoaderError(). The ResourceTimingInfo was
already being discarded in that method, so instead we report the entry
as resources with error statuses must be reported.

Bug: 883400
Change-Id: I72e95b79f70f10b3f1f9c18a8053d2a31f5a6008
Reviewed-on: https://chromium-review.googlesource.com/2181828
WPT-Export-Revision: 13739dfe1e93a04238470da42b6f1fc1b52325b5

Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 73 tests

Status Summary

Firefox

OK : 2
PASS: 5[GitHub] 76[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 61

Chrome

OK : 2
PASS: 56
FAIL: 10

Safari

OK : 2
PASS: 38
FAIL: 28

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/preload/subresource-integrity.html
Same-origin style with sha256 mismatch, sha512 match: FAIL
Same-origin script with correct hash, options.: FAIL
Same-origin style with correct hash, options.: FAIL
Same-origin image with correct hash, options.: FAIL
Same-origin script with multiple sha256 hashes, including correct.: FAIL
Same-origin script with empty integrity.: FAIL
Same-origin image with correct sha256 hash.: FAIL
Same-origin style with unknown algorithm only.: FAIL
Cross-origin image, empty integrity: FAIL
Same-origin image with multiple sha256 hashes, including correct.: FAIL
Same-origin script with correct sha512 hash.: FAIL
<crossorigin='use-credentials'> image with correct hash, CORS-eligible: FAIL
Same-origin style with multiple sha256 hashes, including unknown algorithm.: FAIL
Same-origin image with correct sha384 hash.: FAIL
<crossorigin='use-credentials'> style with correct hash, CORS-eligible: FAIL
Same-origin script with matching digest re-uses preload with matching digest.: FAIL
Same-origin style with correct sha512 hash.: FAIL
Same-origin style with correct sha256 hash.: FAIL
Same-origin script with correct sha256 hash.: FAIL
Same-origin image with sha256 mismatch, sha512 match: FAIL
Same-origin style with multiple sha256 hashes, including correct.: FAIL
Cross-origin script, empty integrity: FAIL
Same-origin script with correct sha384 hash.: FAIL
Same-origin style with matching digest re-uses preload with matching digest.: FAIL
Same-origin image with correct sha512 hash.: FAIL
Same-origin image with unknown algorithm only.: FAIL
Same-origin script with unknown algorithm only.: FAIL
<crossorigin='use-credentials'> script with correct hash, CORS-eligible: FAIL
Same-origin script with sha256 mismatch, sha512 match: FAIL
Same-origin image with empty integrity.: FAIL
Same-origin style with empty integrity.: FAIL
Same-origin script with multiple sha256 hashes, including unknown algorithm.: FAIL
<crossorigin='anonymous'> image with correct hash, ACAO: *: FAIL
<crossorigin='anonymous'> script with correct hash, ACAO: *: FAIL
Same-origin style with correct sha384 hash.: FAIL
Same-origin image with multiple sha256 hashes, including unknown algorithm.: FAIL
Cross-origin style, empty integrity: FAIL
<crossorigin='anonymous'> style with correct hash, ACAO: *: FAIL

New Tests That Don't Pass

/preload/subresource-integrity.html
Same-origin style with sha256 mismatch, sha512 match: FAIL (Chrome: PASS, Safari: PASS)
Same-origin script with correct hash, options.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin style with correct hash, options.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin image with sha256 match, sha512 mismatch: FAIL (Chrome: FAIL, Safari: FAIL)
Same-origin script with non-matching digest does not re-use preload with matching digest.: FAIL (Chrome: PASS, Safari: FAIL)
Cross-origin script, not CORS request, with hash mismatch: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin image with correct hash, options.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin script with multiple sha256 hashes, including correct.: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='use-credentials'> style with incorrect hash CORS-eligible: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin script with empty integrity.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin script with sha256 match, sha512 mismatch: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin image with correct sha256 hash.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin style with unknown algorithm only.: FAIL (Chrome: PASS, Safari: PASS)
Cross-origin image, empty integrity: FAIL (Chrome: PASS, Safari: PASS)
Same-origin image with multiple sha256 hashes, including correct.: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='use-credentials'> script with incorrect hash CORS-eligible: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin image with incorrect hash.: FAIL (Chrome: FAIL, Safari: FAIL)
Same-origin script with correct sha512 hash.: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='use-credentials'> image with correct hash, CORS-eligible: FAIL (Chrome: PASS, Safari: PASS)
Same-origin style with sha256 match, sha512 mismatch: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin style with multiple sha256 hashes, including unknown algorithm.: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='anonymous'> image with CORS-ineligible resource: FAIL (Chrome: FAIL, Safari: FAIL)
Cross-origin image, not CORS request, with hash mismatch: FAIL (Chrome: FAIL, Safari: FAIL)
<crossorigin='anonymous'> script with CORS-ineligible resource: FAIL (Chrome: FAIL, Safari: FAIL)
Same-origin image with correct sha384 hash.: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='use-credentials'> style with correct hash, CORS-eligible: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='use-credentials'> image with incorrect hash CORS-eligible: FAIL (Chrome: FAIL, Safari: FAIL)
Same-origin script with matching digest re-uses preload with matching digest.: FAIL (Chrome: PASS, Safari: PASS)
Cross-origin image, not CORS request, with correct hash: FAIL (Chrome: FAIL, Safari: FAIL)
<crossorigin='anonymous'> style with incorrect hash, ACAO: *: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin style with correct sha512 hash.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin style with correct sha256 hash.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin script with correct sha256 hash.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin image with sha256 mismatch, sha512 match: FAIL (Chrome: PASS, Safari: PASS)
Cross-origin style, not CORS request, with hash mismatch: FAIL (Chrome: PASS, Safari: FAIL)
Cross-origin style, not CORS request, with correct hash: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin style with multiple sha256 hashes, including correct.: FAIL (Chrome: PASS, Safari: PASS)
Cross-origin script, empty integrity: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='anonymous'> script with incorrect hash, ACAO: *: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin script with correct sha384 hash.: FAIL (Chrome: PASS, Safari: PASS)
Cross-origin script, not CORS request, with correct hash: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin style with matching digest re-uses preload with matching digest.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin script with incorrect hash.: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin image with correct sha512 hash.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin image with unknown algorithm only.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin script with unknown algorithm only.: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='use-credentials'> script with correct hash, CORS-eligible: FAIL (Chrome: PASS, Safari: PASS)
Same-origin style with incorrect hash.: FAIL (Chrome: PASS, Safari: FAIL)
Same-origin script with sha256 mismatch, sha512 match: FAIL (Chrome: PASS, Safari: PASS)
Same-origin image with empty integrity.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin style with empty integrity.: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='anonymous'> style with CORS-ineligible resource: FAIL (Chrome: FAIL, Safari: FAIL)
Same-origin script with multiple sha256 hashes, including unknown algorithm.: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='anonymous'> image with incorrect hash, ACAO: *: FAIL (Chrome: FAIL, Safari: FAIL)
<crossorigin='anonymous'> image with correct hash, ACAO: *: FAIL (Chrome: PASS, Safari: PASS)
<crossorigin='anonymous'> script with correct hash, ACAO: *: FAIL (Chrome: PASS, Safari: PASS)
Same-origin style with correct sha384 hash.: FAIL (Chrome: PASS, Safari: PASS)
Same-origin image with multiple sha256 hashes, including unknown algorithm.: FAIL (Chrome: PASS, Safari: PASS)
Cross-origin style, empty integrity: FAIL (Chrome: PASS, Safari: PASS)
Same-origin style with non-matching digest does not re-use preload with matching digest.: FAIL (Chrome: PASS, Safari: FAIL)
<crossorigin='anonymous'> style with correct hash, ACAO: *: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/580f0a6ef09a
[wpt PR 23412] - [ResourceTiming] Dispatch entry for 404 scripts, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/877e73caedb3
[wpt PR 23412] - [ResourceTiming] Dispatch entry for 404 scripts, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.