1635677 - ReferenceError: Components is not defined

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:

1. Load https://edition.cnn.com/
2. Open DevTools and select the Network panel
3. Refresh the page
4. Check out the Browser Console for bunch of errors:

ReferenceError: Components is not defined network-response-listener.js:86:5

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This looks like a recent regression.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

It looks like the exception happens when query for nsJSID interface is happening.

Some analysis/questions:

1. Should we just define Components or throw new Error("Not supported interface"); or throw Cr.NS_ERROR_NO_INTERFACE;?
2. Could we finally remove the following piece of code introduced in bug 1309523?
   https://searchfox.org/mozilla-central/rev/7908ce29657cfd623993046bd8e38664e1c0b28e/devtools/server/actors/network-monitor/network-response-listener.js#56-60
   The comment says that it's for the non-e10s case only.

In any case having the regression window would help here.

Honza

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:Honza, if you think that's a regression, then could you try to find a regression range in using for example mozregression?

Comment 4

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e0f2683f03168b7de89dc9f15ee7c07db3004f65&tochange=f0db8d736910768f6fa76bd9606f90270cb476a4

Comment 5

[Ian Moody [:Kwan] (UTC+0)]

My fault, apologies.

Comment 6

[Ian Moody [:Kwan] (UTC+0)]

Attachment: Bug 1635677 - Import Components in devtools so Components.Exceptions can be thrown. r=Honza

This was a regression from automated changes in bug 1536556
6936e9640d4e41b2c470a022a2e7066b72b7d906

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Alice0775 White from comment #4)

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e0f2683f03168b7de89dc9f15ee7c07db3004f65&tochange=f0db8d736910768f6fa76bd9606f90270cb476a4

Thanks Alice for the regression window, that was great help!

Honza

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b06710fbea63
Import Components in devtools so Components.Exceptions can be thrown. r=Honza

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1536556

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b06710fbea63