1635684 - [MIPS] Failed to build js on mips64 (error: no matching member function for call to 'bailoutTest32')

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Zhao Jiazhong]

User Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Try to build js on mips64 platform, changeset: 385f49adaf00.

Actual results:

Got error message:

/home/loongson/disk/firefox-central/js/src/jit/CodeGenerator.cpp:4572:3: error: no matching member function for call to 'bailoutTest32'
bailoutTest32(Assembler::Zero, Address(str, JSString::offsetOfFlags()),
^~~~~~~~~~~~~
/home/loongson/disk/firefox-central/js/src/jit/mips-shared/CodeGenerator-mips-shared.h:51:8: note: candidate function template not viable: no known conversion from 'js::jit::Address' to 'js::jit::Register' for 2nd argument
void bailoutTest32(Assembler::Condition c, Register lhs, T rhs,
^
1 error generated.

Expected results:

Build js successfully.

Comment 1

[Zhao Jiazhong]

This bug seems to be introduced at changeset 687246f618fb:

+  bailoutTest32(Assembler::Zero, Address(str, JSString::offsetOfFlags()),
+                Imm32(JSString::NON_ATOM_BIT), guard->snapshot());

Becuase bailoutTest32 on mips only accept Register type value as second argument:

template <typename T>
void bailoutTest32(Assembler::Condition c, Register lhs, T rhs,
                   LSnapshot* snapshot) {
...
}

Comment 2

[Zhao Jiazhong]

Attachment: Bug 1635684 - [MIPS] Change bailoutTest32's second parameter to generic type. r=lth

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aa7584b8e0e
[MIPS] Change bailoutTest32's second parameter to generic type. r=lth

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7aa7584b8e0e