1635689 - Stop generating get() methods for unions

Status: RESOLVED FIXED

(Core :: IPC, task)

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

For context, this is about the overloaded get method with a pointer out param, which needs to copy out the contained value, which is a problem for non-copyable types. Nika thinks that they're not actually used (vs. the get_TypeName methods) and we could probably just delete the code for them entirely.

(The code appears to be here if I understand lower.py correctly.)

Comment 2

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1635689 - Part 1: Stop using 'get' method on IPDL unions in gfxVars.h,

This code is the only caller of this generated method.

Comment 3

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Bug 1635689 - Part 2: Stop generating 'get' method on IPDL unions,

This method always copies, and is redundant with the other getter methods on
IPDL unions. As there is only one caller, it can be removed to simplify the
code, and remove a source of complexity.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc7f55903e90
Part 1: Stop using 'get' method on IPDL unions in gfxVars.h, r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/3d76df0fb77c
Part 2: Stop generating 'get' method on IPDL unions, r=jld

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/fc7f55903e90
https://hg.mozilla.org/mozilla-central/rev/3d76df0fb77c