1635692 - Store the cell's trace kind in the nursery cell header

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Jon Coppeard (:jonco)]

Following on from bug 1635087, we can store the nursery cell trace kind in its header instead of setting flag bits in the first word of the cell. The flag bits will remain reserved for future use by the GC.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1635692 - Store trace kind in nursery cell header and remove nursery cell kind flags r?sfink

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1635692 - Move JSString::NON_ATOM_BIT so that it doesn't use one of the bits reserved for the GC r?jandem

It looks like we can use bit 3 for this instead.

Depends on D74022

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1635692 - Invert JSString::NON_ATOM_BIT so it's now ATOM_BIT r?jandem

We shouldn't need to store this inverted any more.

Depends on D74023

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af22c6d0af23
Store trace kind in nursery cell header and remove nursery cell kind flags r=sfink
https://hg.mozilla.org/integration/autoland/rev/6648ecc63106
Move JSString::NON_ATOM_BIT so that it doesn't use one of the bits reserved for the GC r=jandem
https://hg.mozilla.org/integration/autoland/rev/e88b38c4bd48
Invert JSString::NON_ATOM_BIT so it's now ATOM_BIT r=jandem

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/af22c6d0af23
https://hg.mozilla.org/mozilla-central/rev/6648ecc63106
https://hg.mozilla.org/mozilla-central/rev/e88b38c4bd48