Closed Bug 1635713 Opened 5 years ago Closed 5 years ago

Add explicit Histogram::SampleSet::Clone method

Categories

(Toolkit :: Telemetry, task, P1)

task
Points:
1

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: sg, Assigned: chutten)

References

Details

Attachments

(1 file)

Rather than relying on implicit copyability, there should be an explicit Histogram::SampleSet::Clone method. Histogram::Counts can be changed to nsTArray then.

Histogram was part of the original Chromium IPC import, but its only user is Telemetry, so it's effectively Telemetry code and I'm going to hand this to them.

Component: IPC → Telemetry
Product: Core → Toolkit

This also removes a copy during clear operations, which is nice I guess.

Assignee: nobody → chutten
Status: NEW → ASSIGNED
Severity: -- → N/A
Points: --- → 1
Priority: -- → P1
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2cfe7cda1426 Be explicit about SampleSet copies r=janerik
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: