Closed Bug 1635722 Opened 5 years ago Closed 5 years ago

Crash in [@ mozilla::a11y::DocAccessiblePlatformExtParent::RecvSetPivotBoundaries]

Categories

(Core :: Disability Access APIs, defect, P3)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- fixed
firefox81 --- fixed

People

(Reporter: fluffyemily, Assigned: eeejay)

References

Details

(Keywords: crash, Whiteboard: [geckoview])

Crash Data

Attachments

(2 files, 1 obsolete file)

This bug is for crash report bp-c4eaf6e7-0e4d-4f9e-a8d4-e6cf00200506.

Top 10 frames of crashing thread:

0 libxul.so mozilla::a11y::DocAccessiblePlatformExtParent::RecvSetPivotBoundaries accessible/ipc/extension/android/DocAccessiblePlatformExtParent.cpp:29
1 libxul.so mozilla::a11y::PDocAccessiblePlatformExtParent::OnMessageReceived ipc/ipdl/PDocAccessiblePlatformExtParent.cpp:389
2 libxul.so mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:6519
3 libxul.so mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2187
4 libxul.so mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1990
5 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
6 libxul.so NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:481
7 libxul.so mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:87
8 libxul.so MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290
9 libxul.so nsBaseAppShell::Run widget/nsBaseAppShell.cpp:137

Component: General → Disability Access APIs
Flags: needinfo?(eitan)
Product: GeckoView → Core
Whiteboard: [geckoview]
Severity: -- → S2

Hi Jamie, could you review the severity (s2) and prioritize this one?

Flags: needinfo?(jteh)

These crashes seemed to have stopped in the last few weeks, so I'm dropping to s3. Eitan, is there anything you might have worked on which might have fixed this?

Severity: S2 → S3
Flags: needinfo?(jteh)
Priority: -- → P3

Could this be reprioritized? we're still seeing crashes with this signature.

Flags: needinfo?(jteh)

The IPC docs of the first/last nodes are not guaranteed to exist. This
could happen early on when the child docs are still hanging and have not
yet been processed in the NotificationController.

Assignee: nobody → eitan
Status: NEW → ASSIGNED
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b566d4ac1ff2 Check node ipc docs before sending pivot boundaries. r=Jamie
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Please nominate this for Beta approval when you get a chance.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Target Milestone: mozilla80 → ---

If it helps the investigation I can repro 100% when toggling reader mode via the toolbar button a few times in a row in Fenix (just keep pressing it as it appears on a reader mode-able site ie on a nytimes article).

https://crash-stats.mozilla.org/report/index/ff70bfff-7a7e-451f-ac28-920d40200802

Thanks, Emily! I'll try to reproduce it here and work on it today.

Flags: needinfo?(eitan)

The new pivot boundaries might consist of accessibles that don't exist
yet in the parent process proxy tree.

I guess we can tweak the timing of the pivot boundaries message to be
sent only after remote tree construction. But this seems like an edge
case that quickly gets corrected after the next cache refresh.

Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5bb2ecb2e12b Check existance of proxy accessibles for pivot boundaries. r=Jamie
Status: NEW → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Sounds like we may want to uplift this once verified in nightly.

Flags: needinfo?(eitan)
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e43038a3c22a Hide text marker range attributes that hammer IPC. r=morgan
See Also: → 1657765
Flags: needinfo?(jteh)

Morgan, maybe you can help with the approval request here? We already built the first GV80 RC build, unfortunately, but it would be good to maybe get this if we respin.

Flags: needinfo?(mreschenberg)

Morgan is on PTO. I think this fell off Eitan's plate, so I've pinged him elsewhere to verify on Nightly and submit an uplift request. I can submit an uplift request without verification if you want it sooner, but I'm guessing we'd prefer verification.

Flags: needinfo?(mreschenberg)

(In reply to Pulsebot from comment #19)

Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e43038a3c22a
Hide text marker range attributes that hammer IPC. r=morgan

I'm guessing this was a mistake and this (Mac) patch has nothing to do with this (Android) bug?

Please do file the uplift request we haven't seen crashes since this landed on central and we'd like to respin 80 rc today.

Flags: needinfo?(jteh)

Comment on attachment 9168522 [details]
Bug 1635722 - Hide text marker range attributes that hammer IPC. r?morgan

Marking this as obsolete because it was associated with the wrong patch. oops!

Attachment #9168522 - Attachment is obsolete: true

Comment on attachment 9167985 [details]
Bug 1635722 - Check existance of proxy accessibles for pivot boundaries. r?Jamie!

Beta/Release Uplift Approval Request

  • User impact if declined: Potential crashes when accessibility is enabled and pages are loaded and reloaded in quick succession.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch just adds a couple of checks in a function. If they fail it is not destructive or fatal in any way.
  • String changes made/needed:
Flags: needinfo?(eitan)
Attachment #9167985 - Flags: approval-mozilla-beta?
Attachment #9167985 - Flags: approval-mozilla-beta? → approval-mozilla-release?
Flags: needinfo?(jteh)

Comment on attachment 9167985 [details]
Bug 1635722 - Check existance of proxy accessibles for pivot boundaries. r?Jamie!

Approved for 80.0rc2.

Attachment #9167985 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: