1635734 - Chat broken in Thunderbird 77 beta for macOS

Status: VERIFIED FIXED

(Chat Core :: General, defect, P1)

Description

[Patrick Cloke [:clokep]]

Just updated to Thunderbird 77 beta 1 and chat is broken. It will not connect. I see the following errors when trying to connect an IRC account:

this._outputStream is undefined socket.jsm:271
    sendString resource:///modules/socket.jsm:271
    sendRawMessage resource:///modules/irc.jsm:2101
    sendMessage resource:///modules/irc.jsm:2059
    quit resource:///modules/irc.jsm:1886
    disconnect resource:///modules/irc.jsm:1905
    disconnect resource:///modules/imAccounts.jsm:884
    disconnect chrome://messenger/content/chat/imAccounts.js:256
    oncommand chrome://messenger/content/chat/imAccounts.xhtml:1
TypeError: browser is null
hiddenWindow.jsm:21:5
NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "browser is null" {file: "resource:///modules/hiddenWindow.jsm" line: 21}]'[JavaScript Error: "browser is null" {file: "resource:///modules/hiddenWindow.jsm" line: 21}]' when calling method: [prplIAccount::connect] imAccounts.jsm:878
    connect resource:///modules/imAccounts.jsm:878
    connect chrome://messenger/content/chat/imAccounts.js:249
    oncommand chrome://messenger/content/chat/imAccounts.xhtml:1

Comment 1

[Magnus Melin [:mkmelin]]

Hmm, I'm connected to #thunderbird-otr with nightly and that seems to work

Comment 2

[Patrick Cloke [:clokep]]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Hmm, I'm connected to #thunderbird-otr with nightly and that seems to work

The hiddenWindow errors point to this probably being macOS only.

Comment 3

[Magnus Melin [:mkmelin]]

Would make sense. Khushil, do you see this?

Comment 4

[Khushil Mistry [:khushil324]]

I am not on trunk. I am updating it and will work on the bug ASAP.

Comment 5

[Khushil Mistry [:khushil324]]

This issue is related to missing the following lines from hiddenWindow.xhtml:

#ifdef MOZ_OPENPGP
<!ENTITY % bondOpenPGPDTD SYSTEM "chrome://openpgp/content/strings/bond.dtd">
%bondOpenPGPDTD;
#endif

Should I create a patch for this and then start working on bug 1635734 or just add this thing in the patch for that bug?

Comment 6

[Khushil Mistry [:khushil324]]

Attachment: Bug-1635734_fix-broken-chat-0.patch

Comment 7

[Patrick Cloke [:clokep]]

Comment on attachment 9146544 [details] [diff] [review]
Bug-1635734_fix-broken-chat-0.patch

Review of attachment 9146544 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonable, but not 100% confident on it.

Comment 8

[Khushil Mistry [:khushil324]]

(In reply to Patrick Cloke [:clokep] from comment #7)

This looks reasonable, but not 100% confident on it.

Have you tried the patch? Any problems?

Comment 9

[Florian Quèze [:florian]]

It's not the first time that there's a hidden window bustage; could someone write an automated test to ensure it's working correctly?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c5def570bb4b
Fix Chat broken in Thunderbird for macOS. r=clokep

Comment 11

[Patrick Cloke [:clokep]]

Comment on attachment 9146544 [details] [diff] [review]
Bug-1635734_fix-broken-chat-0.patch

[Approval Request Comment]
Regression caused by (bug #): Likely bug 1631198 or bug 1631247
User impact if declined: Chat doesn't work on macOS
Testing completed (on c-c, etc.): None
Risk to taking this patch (and alternatives if risky): I don't think this will break things more. :)

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9146544 [details] [diff] [review]
Bug-1635734_fix-broken-chat-0.patch

Thank for the patch

Comment 13

[Geoff Lankow (:darktrojan)]

77.0b2: https://hg.mozilla.org/releases/comm-beta/rev/f25512b597325260e72b0f45e06d2f6ac9f6dc7b

Comment 14

[Patrick Cloke [:clokep]]

Verified in 77.0b2 that this is fixed! Thanks!