Closed Bug 1635813 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23417 - CookieStore: Add domain validation wpt for cookieStore.delete

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23417 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23417
Details from upstream follow.

Ayu Ishii <ayui@chromium.org> wrote:

CookieStore: Add domain validation wpt for cookieStore.delete

This change adds tests for domain validation in wpt for
cookieStore.delete.

Addresses comment: https://chromium-review.googlesource.com/c/chromium/src/+/2149699/2#message-e82e06fcb5fdc9ffb82e425114b2fc2adbf7d36c

Bug: 729800
Change-Id: I3c12a5f6e2f8504d1b4c327120ec17af9be060b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2183193
Commit-Queue: Ayu Ishii \<ayui@chromium.org>
Reviewed-by: Victor Costan \<pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765866}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 73 tests

Status Summary

Firefox

OK : 2
PASS: 71
FAIL: 32

Chrome

OK : 2
PASS: 32

Safari

OK : 2
FAIL: 32

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookie-store/cookieStore_delete_arguments.tentative.https.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
cookieStore.delete with path that does not start with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options and domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to subdirectory of the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete domain starts with ".": FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options and domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options and domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain that is not equal current host: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with get result: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with missing / at the end of path: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in both positional arguments and options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with positional name: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
/cookie-store/cookieStore_delete_arguments.tentative.https.any.serviceworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
cookieStore.delete with path that does not start with /: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options and domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with path set to subdirectory of the current directory: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete domain starts with ".": FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options and domain set to a subdomain of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in options and domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain that is not equal current host: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with get result: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with missing / at the end of path: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with name in both positional arguments and options: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with positional name: FAIL (Chrome: PASS, Safari: FAIL)
cookieStore.delete with domain set to a non-domain-matching suffix of the current hostname: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/cookie-store/cookieStore_delete_arguments.tentative.https.any.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/cookie-store/cookieStore_delete_arguments.tentative.https.any.serviceworker.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f021dcb83231
[wpt PR 23417] - CookieStore: Add domain validation wpt for cookieStore.delete, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2dfaa81e18b5
[wpt PR 23417] - CookieStore: Add domain validation wpt for cookieStore.delete, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.