Closed Bug 1635904 Opened 4 years ago Closed 4 years ago

Do correct process selection in the WPT reftest harness

Categories

(Remote Protocol :: Marionette, defect)

defect

Tracking

(Fission Milestone:M6b, firefox78 fixed)

RESOLVED FIXED
mozilla78
Fission Milestone M6b
Tracking Status
firefox78 --- fixed

People

(Reporter: u608768, Assigned: u608768)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1599662 +++

This is mostly identical to bug 1599662, except for the WPT reftest harness.

There's a detailed breakdown in bug 1622347 comment 9 as to why this is necessary.

I think this is also the root cause for many of the "SecurityError: Permission denied to access property "windowUtils" on cross-origin object" failures that we're seeing (bug 1574508, bug 1625410).

Blocks: 1622347

This bug will make it so that top-level documents and their subframes end up in the same process (bug 1599662 did this for non-wpt reftests). I'm still unsure if this will fix all of the cross-origin "windowUtils" errors, so we may need to do something like bug 1593170 as well (which is what bug 1574508 is for).

From my initial try push, it looks like this will fix the following tests:

testing/web-platform/meta/css/compositing/mix-blend-mode/mix-blend-mode-iframe-parent.html.ini
testing/web-platform/meta/css/compositing/mix-blend-mode/mix-blend-mode-iframe-sibling.html.ini
testing/web-platform/meta/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background-mismatch-alpha.html.ini
testing/web-platform/meta/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background-mismatch-opaque.html.ini
testing/web-platform/meta/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background.html.ini
testing/web-platform/meta/css/css-contain/contain-size-replaced-003a.html.ini
testing/web-platform/meta/css/css-contain/contain-size-replaced-003b.html.ini
testing/web-platform/meta/css/css-contain/contain-size-replaced-003c.html.ini
testing/web-platform/meta/css/css-display/display-change-iframe.html.ini
testing/web-platform/meta/css/css-images/image-orientation/image-orientation-from-image-embedded-content.html.ini
testing/web-platform/meta/css/css-images/image-orientation/image-orientation-none-image-document.html.ini
testing/web-platform/meta/css/css-position/position-sticky-fixed-ancestor-iframe.html.ini
testing/web-platform/meta/css/css-scroll-snap/scroll-target-align-001.html.ini
testing/web-platform/meta/css/css-scroll-snap/scroll-target-margin-001.html.ini
testing/web-platform/meta/css/css-scroll-snap/scroll-target-padding-001.html.ini
testing/web-platform/meta/css/css-scroll-snap/scroll-target-snap-001.html.ini
testing/web-platform/meta/css/css-scrollbars/viewport-scrollbar-body.html.ini
testing/web-platform/meta/css/css-scrollbars/viewport-scrollbar.html.ini
testing/web-platform/meta/css/css-sizing/dynamic-available-size-iframe.html.ini
testing/web-platform/meta/css/css-transforms/transform-iframe-001.html.ini
testing/web-platform/meta/css/css-values/vh-support-transform-origin.html.ini
testing/web-platform/meta/css/css-values/vh-support-transform-translate.html.ini
testing/web-platform/meta/css/css-values/vh_not_refreshing_on_chrome.html.ini
testing/web-platform/meta/css/css-writing-modes/background-size-document-root-vrl-002.html.ini
testing/web-platform/meta/css/css-writing-modes/background-size-document-root-vrl-004.html.ini
testing/web-platform/meta/css/css-writing-modes/background-size-document-root-vrl-006.html.ini
testing/web-platform/meta/css/css-writing-modes/background-size-document-root-vrl-008.html.ini
testing/web-platform/meta/css/filter-effects/svg-relative-urls-001.html.ini
testing/web-platform/meta/css/mediaqueries/min-width-tables-001.html.ini
testing/web-platform/meta/css/vendor-imports/mozilla/mozilla-central-reftests/selectors4/focus-within-3.html.ini
testing/web-platform/meta/feature-policy/experimental-features/vertical-scroll-disabled-scrollbar-tentative.html.ini
testing/web-platform/meta/forced-colors-mode/forced-colors-mode-06.html.ini
testing/web-platform/meta/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute-values.html.ini
testing/web-platform/meta/html/rendering/non-replaced-elements/the-page/iframe-scrolling-attribute.html.ini
testing/web-platform/meta/html/semantics/embedded-content/the-iframe-element/iframe-modify-scrolling-attr-to-yes.html.ini
testing/web-platform/meta/html/semantics/embedded-content/the-iframe-element/iframe-with-base.html.ini
testing/web-platform/meta/html/semantics/embedded-content/the-img-element/adopt-from-image-document.html.ini
testing/web-platform/meta/html/the-xhtml-syntax/parsing-xhtml-documents/adopt-while-parsing-001.html.ini
testing/web-platform/meta/mathml/relations/html5-tree/unique-identifier-1.html.ini
testing/web-platform/meta/service-workers/service-worker/svg-target-reftest.https.html.ini
testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/embedded_style_media_queries.html.ini
testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/embedded_style_media_queries_resized.html.ini
testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/navigate_cue_position.html.ini
See Also: → 1574508

DocumentLoadListener doesn't know how to process-switch top-level loads for
non-tabbed browsers, so this ensures that the load happens in the correct
process.

These no longer error or fail when fission is enabled.

Depends on D74272

Blocks: 1620707
Blocks: 1622364
Blocks: 1622376
Blocks: 1623449
Blocks: 1623459
Blocks: 1623455
Fission Milestone: M6 → M6b
Pushed by kmadan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba79a6106eac
Manually set the <browser>'s remote type before initiating a new load, r=mattwoodrow,jgraham,marionette-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/a4712768f15d
Update fission test expectations, r=jgraham

Because this bug's Severity is normal and has not been changed, and this bug's priority is -- (none,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Severity: normal → --
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
Product: Testing → Remote Protocol
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: