Closed
Bug 1635958
Opened 4 years ago
Closed 4 years ago
Warp: Transpile even more compare ops
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla78
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
This gives us comparisons between {int, boolean} x {int, boolean}.
To be closer to CacheIR we should actually convert the result of GuardToBoolean to an int32. I am not sure if that is the way to go?
I think MCompare::Compare_Int32MaybeCoerceBoth gets us closer to the correct TypePolicy from the MCompare side instead of GuardToBoolean.
Assignee | ||
Updated•4 years ago
|
Summary: Warp: Transpile even compare ops → Warp: Transpile even more compare ops
Updated•4 years ago
|
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f9356df325cd Warp: Transpile GuardToBoolean. r=jandem
Comment 3•4 years ago
|
||
bugherder |
Assignee | ||
Comment 4•4 years ago
|
||
For "StrictDifferentTypes" we emit LoadValueTag + GuardTagNotEqual. We never use LoadValueTag anywhere else. I think it would be simpler to just fold the tag loading and comparison into GuardTagNotEqual and get rid of LoadValueTag. We would still have to actually implement a new MIR instruction for this... I think I might just ignore that case for now.
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Depends on D74344
Assignee | ||
Comment 7•4 years ago
|
||
Depends on D74345
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bfb077281e6e Warp: Transpile GuardIsNullOrUndefined. r=jandem https://hg.mozilla.org/integration/autoland/rev/bd9919221ebd Warp: Transpile LoadBooleanResult. r=jandem https://hg.mozilla.org/integration/autoland/rev/97e4cf641476 Remove unused GuardIsNotNullOrUndefined. r=jandem
Comment 9•4 years ago
|
||
bugherder |
Assignee | ||
Comment 10•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Keywords: leave-open
Comment 11•4 years ago
|
||
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2cedd5be6442 Warp: Transpile GuardIsNull/Undefined. r=jandem
Comment 12•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•