Closed Bug 1635958 Opened 4 years ago Closed 4 years ago

Warp: Transpile even more compare ops

Categories

(Core :: JavaScript Engine: JIT, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

No description provided.

This gives us comparisons between {int, boolean} x {int, boolean}.

To be closer to CacheIR we should actually convert the result of GuardToBoolean to an int32. I am not sure if that is the way to go?
I think MCompare::Compare_Int32MaybeCoerceBoth gets us closer to the correct TypePolicy from the MCompare side instead of GuardToBoolean.

Summary: Warp: Transpile even compare ops → Warp: Transpile even more compare ops
Severity: -- → N/A
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f9356df325cd
Warp: Transpile GuardToBoolean. r=jandem

For "StrictDifferentTypes" we emit LoadValueTag + GuardTagNotEqual. We never use LoadValueTag anywhere else. I think it would be simpler to just fold the tag loading and comparison into GuardTagNotEqual and get rid of LoadValueTag. We would still have to actually implement a new MIR instruction for this... I think I might just ignore that case for now.

Depends on D74344

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bfb077281e6e
Warp: Transpile GuardIsNullOrUndefined. r=jandem
https://hg.mozilla.org/integration/autoland/rev/bd9919221ebd
Warp: Transpile LoadBooleanResult. r=jandem
https://hg.mozilla.org/integration/autoland/rev/97e4cf641476
Remove unused GuardIsNotNullOrUndefined. r=jandem
Keywords: leave-open
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2cedd5be6442
Warp: Transpile GuardIsNull/Undefined. r=jandem
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: