1635958 - Warp: Transpile even more compare ops

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Comment 1

[Tom S]

Attachment: Bug 1635958 - Warp: Transpile GuardToBoolean. r?jandem

This gives us comparisons between {int, boolean} x {int, boolean}.

To be closer to CacheIR we should actually convert the result of GuardToBoolean to an int32. I am not sure if that is the way to go?
I think MCompare::Compare_Int32MaybeCoerceBoth gets us closer to the correct TypePolicy from the MCompare side instead of GuardToBoolean.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9356df325cd
Warp: Transpile GuardToBoolean. r=jandem

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f9356df325cd

Comment 4

[Tom S]

For "StrictDifferentTypes" we emit LoadValueTag + GuardTagNotEqual. We never use LoadValueTag anywhere else. I think it would be simpler to just fold the tag loading and comparison into GuardTagNotEqual and get rid of LoadValueTag. We would still have to actually implement a new MIR instruction for this... I think I might just ignore that case for now.

Comment 5

[Tom S]

Attachment: Bug 1635958 - Warp: Transpile GuardIsNullOrUndefined. r?jandem

Comment 6

[Tom S]

Attachment: Bug 1635958 - Warp: Transpile LoadBooleanResult. r?jandem

Depends on D74344

Comment 7

[Tom S]

Attachment: Bug 1635958 - Remove unused GuardIsNotNullOrUndefined. r?jandem

Depends on D74345

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfb077281e6e
Warp: Transpile GuardIsNullOrUndefined. r=jandem
https://hg.mozilla.org/integration/autoland/rev/bd9919221ebd
Warp: Transpile LoadBooleanResult. r=jandem
https://hg.mozilla.org/integration/autoland/rev/97e4cf641476
Remove unused GuardIsNotNullOrUndefined. r=jandem

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bfb077281e6e
https://hg.mozilla.org/mozilla-central/rev/bd9919221ebd
https://hg.mozilla.org/mozilla-central/rev/97e4cf641476

Comment 10

[Tom S]

Attachment: Bug 1635958 - Warp: Transpile GuardIsNull/Undefined. r?jandem

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2cedd5be6442
Warp: Transpile GuardIsNull/Undefined. r=jandem

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2cedd5be6442