Closed Bug 1636000 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23447 - [idle] Merge IdleState attributes into IdleDetector

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23447 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23447
Details from upstream follow.

Reilly Grant <reillyg@chromium.org> wrote:

[idle] Merge IdleState attributes into IdleDetector

The IdleState interface adds unnecessary overhead (code size and memory
usage). These attributes can be added directly to the IdleDetector
interface.

Explainer PR: https://github.com/samuelgoto/idle-detection/pull/22

Bug: 878979
Change-Id: Ic92f5fff0ee540d640dc009d391a60c372490bfc
Reviewed-on: https://chromium-review.googlesource.com/2186655
WPT-Export-Revision: eeaa979b888c4142268ab97f2eba9f07697c09c0

PR 23447 applied with additional changes from upstream: 6d1a21bee19885b49dddb5cd234beea4e162b306, d567a81805f4614a0a4d295bee11e9fee99aa219
PR 23447 applied with additional changes from upstream: 6d1a21bee19885b49dddb5cd234beea4e162b306, d567a81805f4614a0a4d295bee11e9fee99aa219, dc329e1a648b156a9c0191357f39344a2a28a037

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 76 tests

Status Summary

Firefox

OK : 3
PASS : 71
FAIL : 4
ERROR : 2
NOTRUN: 12

Chrome

OK : 4
PASS : 35
FAIL : 17
ERROR : 1

Safari

OK : 3
FAIL : 4
ERROR : 2
NOTRUN: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/idle-detection/idle-permission.tentative.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Deny notifications permission should work.: FAIL (Chrome: PASS, Safari: FAIL)
Grant notifications permission should work.: FAIL (Chrome: FAIL, Safari: FAIL)
/idle-detection/basics.tentative.https.window.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
start() rejects with invalid threshold (NaN): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() rejects with invalid threshold (-1): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() allows threshold (61000): NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() uses a default value for the threshold: NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() rejects with threshold below minimum (59000): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() uses a default value for the threshold when none is passed: NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() rejects with invalid threshold (null): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() uses threshold property: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() rejects with invalid threshold (0): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() basics: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() rejects threshold (60000): NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() uses signal property: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
/idle-detection/idlharness-worker.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Run idlharness tests in a worker.: FAIL (Chrome: PASS, Safari: FAIL)
/idle-detection/interceptor.https.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: ERROR, Safari: ERROR)
/idle-detection/idlharness.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Test IDL implementation of Idle Detection API: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/idle-detection/idle-permission.tentative.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/idle-detection/basics.tentative.https.window.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: ERROR)
/idle-detection/idlharness-worker.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/idle-detection/interceptor.https.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: ERROR, Safari: ERROR)
/idle-detection/idlharness.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ed863230896
[wpt PR 23447] - [idle] Merge IdleState attributes into IdleDetector, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c48fdd11379d
[wpt PR 23447] - [idle] Merge IdleState attributes into IdleDetector, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.