1636045 - [wpt-sync] Sync PR 23420 - Fix "auto" outline with padding and overflowing inline descendants

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23420 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23420
Details from upstream follow.

Manuel Rego Casasnovas <[e-mail]> wrote:

Fix "auto" outline with padding and overflowing inline descendants

This patch fixes a regression in LayoutNG compared to legacy,
when the descendant of an element with padding and "outline: auto"
is an inline block.
And also when it's an inline element (which was not working properly
in legacy layout either, that's why outline-025 and outline-026 tests
fail on legacy).

We need to rebaseline an old pixel test, as we're coming back
to the legacy layout behavior for it.

BUG=1078539
TEST=external/wpt/css/css-ui/outline-024.html
TEST=external/wpt/css/css-ui/outline-025.html
TEST=external/wpt/css/css-ui/outline-026.html

Change-Id: I8ccf72fb34e1d9ce6821eec9312f1fecd52e1281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182471
Reviewed-by: Xianzhu Wang \<[e-mail]>
Reviewed-by: Koji Ishii \<[e-mail]>
Commit-Queue: Manuel Rego \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#766312}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f020bb782288b048bfde38a3370337fc87659278

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

FAIL: 3

Safari

FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/023fc1d6e3ae
[wpt PR 23420] - Fix "auto" outline with padding and overflowing inline descendants, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8db0cdde1d28
[wpt PR 23420] - Fix "auto" outline with padding and overflowing inline descendants, a=testonly

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8db0cdde1d28