1636142 - Make dom arena only enabled in early beta

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Sean Feng [:sefeng211]]

Make dom arena only enabled in early beta so that we can have more time to verify it and gathering more information about it.

Comment 1

[Sean Feng [:sefeng211]]

Attachment: Bug 1636142 - Make DOM Arena is only enabled in early beta r=smaug

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5719d49dccd6
Make DOM Arena is only enabled in early beta r=smaug

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5719d49dccd6

Comment 4

[Sean Feng [:sefeng211]]

Attachment: beta-uplift-request.txt

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1624321
[User impact if declined]: End users may experience some crashes that are not expected
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Yes, In Nightly and early Beta, dom.arena_allocator.enabled pref should be true. In late Beta and Release, it should be false.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: This patch just flips the DOM nodes allocation methodology back to what we have in previous releases.
[String changes made/needed]: None

Comment 5

[Pascal Chevrel:pascalc]

Sean, you didn't attach a patch to your uplift request, you attached the text of the uplift request form. Could you provide a patch to beta and if it is just a reference to the m-c one make sure that it applies cleanly to the beta branch? Thanks

Comment 6

[Sean Feng [:sefeng211]]

Hi Pascal,

Sorry about that. Yeah, it is the m-c one that is attached to this bug, and it applies to beta branch cleanly (just tested).

Thanks!

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9146797 [details]
beta-uplift-request.txt

Thanks, uplift approved for beta.

Comment 8

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/8889d0ef03ba

Comment 9

[Camelia Badau [:cbadau], Desktop Test Engineering]

Is there a specific area that can be affected by the dom.arena_allocator.enabled pref and needs some exploratory testing around it?

Comment 10

[Sean Feng [:sefeng211]]

No, not really. This pref doesn't expose anything visually that can be changed. I think as long as the pref is false for late Beta and Release, we are good.

Comment 11

[Marcela (Please NI request to Brindusa Tot)]

Verified-Fixed on latest Nightly 78.0a1 (2020-05-18) and Beta 77.0b7 on Windows 10, macOS 10.14 and Ubuntu 18.04, dom.arena_allocator.enabled pref is defined as true.
I'll change flags accordingly.

Comment 12

[Marcela (Please NI request to Brindusa Tot)]

Hi, seems that early beta ended last week, so Beta 77.0b7 should be in late beta and the pref dom.arena_allocator.enabled should be false.
Feng, could you please take a look at this? Currently, the pref on Beta 77.0b7 is True. Sorry for misunderstanding this!

Comment 13

[Pascal Chevrel:pascalc]

(In reply to Marcela from comment #12)

Hi, seems that early beta ended last week, so Beta 77.0b7 should be in late beta and the pref dom.arena_allocator.enabled should be false.
Feng, could you please take a look at this? Currently, the pref on Beta 77.0b7 is True. Sorry for misunderstanding this!

We landed the patch to end early betas too late and for this cycle the first late beta build will be beta 8, sorry for the inconvenience it caused.

Comment 14

[Marcela (Please NI request to Brindusa Tot)]

Verified on Beta 77.0b8 and pref is false. I'll change the flag accordingly.