Closed Bug 1636172 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23463 - Improve error handling in iframe-related Generic Sensor tests.

Tracking

(firefox78 fixed)

Status:

RESOLVED FIXED

Milestone:

mozilla78

Tracking Flags:

Tracking

Status

firefox78

---

fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Description

•

5 years ago

Sync web-platform-tests PR 23463 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23463
Details from upstream follow.

Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> wrote:

Improve error handling in iframe-related Generic Sensor tests.

AbsoluteOrientationSensor-iframe-access.https.html has been flaky on the Mac
bots, but there is very little information when the error occurs. All we get
so far is:
 FAIL AbsoluteOrientationSensor: sensor is not suspended when focus traverses from to same-origin frame promise_test: Unhandled rejection with value: undefined
which probably means one of the await statements are call something that
returns a rejected promise, and my first guess is send_message_to_iframe().

Try to make the errors more obvious when they occur again:

Make send_message_to_iframe() reject the promise when the iframe returns
an invalid command.
_ Make send_message_to_iframe() include a message with more information when
it receives an unexpected reply.

Stop shadowing |e| with an exception when something goes wrong in
iframe_sensor_handler.html.

Bug: 1073865
Change-Id: Ib88edfc924e4b8b922a54a97f8ef2ee49b5d0e55
Reviewed-on: https://chromium-review.googlesource.com/2187318
WPT-Export-Revision: 7cb4af6709fcda2fdf52e555c5ea5edefb34f2e9

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

5 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=04287cc9602f16efd91d17e4d980d38ff3e954a2

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

5 years ago

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 79 tests

Status Summary

Firefox

OK : 8
PASS: 71
FAIL: 33

Chrome

OK : 8
FAIL: 33

Safari

OK : 8
FAIL: 33

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/orientation-sensor/RelativeOrientationSensor-iframe-access.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
RelativeOrientationSensor: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
RelativeOrientationSensor: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
RelativeOrientationSensor: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
/gyroscope/Gyroscope-iframe-access.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Gyroscope: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
Gyroscope: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
Gyroscope: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
/magnetometer/Magnetometer-iframe-access.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Magnetometer: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
UncalibratedMagnetometer: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
UncalibratedMagnetometer: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
Magnetometer: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
Magnetometer: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
UncalibratedMagnetometer: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
/proximity/ProximitySensor-iframe-access.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
ProximitySensor: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
ProximitySensor: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
ProximitySensor: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
/ambient-light/AmbientLightSensor-iframe-access.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
AmbientLightSensor: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
AmbientLightSensor: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
AmbientLightSensor: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-sensor/AbsoluteOrientationSensor-iframe-access.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
AbsoluteOrientationSensor: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
AbsoluteOrientationSensor: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
AbsoluteOrientationSensor: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
/geolocation-sensor/GeolocationSensor-iframe-access.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
GeolocationSensor: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
GeolocationSensor: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
GeolocationSensor: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
/accelerometer/Accelerometer-iframe-access.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Accelerometer: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
GravitySensor: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
GravitySensor: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
LinearAccelerationSensor: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
LinearAccelerationSensor: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
Accelerometer: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
GravitySensor: losing a document's frame with an active sensor does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
Accelerometer: sensor is not suspended when focus traverses from to same-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)
LinearAccelerationSensor: sensor is suspended and resumed when focus traverses from to cross-origin frame: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

5 years ago

Depends on: 1637486

Pulsebot

Comment 3

•

5 years ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c3f93564684 [wpt PR 23463] - Improve error handling in iframe-related Generic Sensor tests., a=testonly

Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)

Assignee

Updated

•

5 years ago

Depends on: 1638272

Pulsebot

Comment 4

•

5 years ago

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7e913365a00 [wpt PR 23463] - Improve error handling in iframe-related Generic Sensor tests., a=testonly

Andreea Pavel [:apavel]

Comment 5

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/e7e913365a00

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox78: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla78

You need to log in before you can comment on or make changes to this bug.

Bugzilla

[wpt-sync] Sync PR 23463 - Improve error handling in iframe-related Generic Sensor tests.

Categories

(Testing :: web-platform-tests, task, P4)

Tracking

(firefox78 fixed)

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Comment 1

Comment 2

CI Results

Status Summary

Firefox

Chrome

Safari

Links

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Updated

Comment 3

Updated

Comment 4

Comment 5