1636178 - 14 /service-worker/service-worker/ tests are marked as expected TIMEOUT

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

I am investigating why we have tests that are expected timeout running regularly with the intent of fixing them or not running them if they are not supported. Here are 14 tests that are failing in service worker:
/service-workers/service-worker/client-navigate.https.html
/service-workers/service-worker/clients-matchall-frozen.https.html
/service-workers/service-worker/fetch-request-css-images.https.html
/service-workers/service-worker/navigation-preload/broken-chunked-encoding.https.html
/service-workers/service-worker/navigation-preload/chunked-encoding.https.html
/service-workers/service-worker/navigation-preload/get-state.https.html
/service-workers/service-worker/navigation-preload/redirect.https.html
/service-workers/service-worker/navigation-preload/request-headers.https.html
/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https.html
/service-workers/service-worker/ServiceWorkerGlobalScope/postmessage.https.html
/service-workers/service-worker/unregister-immediately-before-installed.https.html
/service-workers/service-worker/unregister-immediately-during-extendable-events.https.html
/service-workers/service-worker/unregister-immediately.https.html
/service-workers/service-worker/update-after-navigation-redirect.https.html

I ran these all locally on windows 10 and confirmed they all failed. These fall into a few buckets and I would be ok splitting these into separate bugs if that is easier.

clear-site-data:
/service-workers/service-worker/unregister-immediately-before-installed.https.html
/service-workers/service-worker/unregister-immediately-during-extendable-events.https.html
/service-workers/service-worker/unregister-immediately.https.html

all 3 of these fail on subtests that are similar to this Clear-Site-Data must abort service worker registration

post loopback messages timeout:
/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https.html
/service-workers/service-worker/ServiceWorkerGlobalScope/postmessage.https.html

both of these tests fail on subtests like this Post loopback messages. On extendable-message-event.https.html I see a test failing with this message:

assert_equals: event `origin` property expected "https://web-platform.test:8443" but got ""

not sure if that helps, but it was more info which I could find.

/service-workers/service-worker/navigation-preload/get-state.https.html fails with ```
Unhandled rejection with value: object "TypeError: can't access property "getState", np is undefined"

@https://web-platform.test:8443/service-workers/service-worker/navigation-preload/get-state.https.html:17:13

possible harness/tooling issues:
/service-workers/service-worker/navigation-preload/request-headers.https.html
/service-workers/service-worker/navigation-preload/chunked-encoding.https.html
both fail for related to:

"JavaScript error: , line 0: uncaught exception: [fluent] Missing translations in en-US: corruptedContentErrorv2-title.

The site at https://web-platform.test:8443/service-workers/service-worker/navigation-preload/resources/chunked-encoding-scope.py has experienced a network protocol violation that cannot be repaired.

The page you are trying to view cannot be shown because an error in the data transmission was detected.

Please contact the website owners to inform them of this problem."

and /service-workers/service-worker/clients-matchall-frozen.https.html:
fails with ```JavaScript error: https://web-platform.test:8443/resources/testdriver.js, line 433: Error: unimplemented```

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:jgraham - could you comment on the few tests near the end where I mention what looks to be test/tooling issues?

:jstutte - could you help me (or redirect me to someone who can) determine if these tests are broken, not implemented, not supported, etc. ?

Comment 2

[James Graham [:jgraham]]

/service-workers/service-worker/navigation-preload/request-headers.https.html
/service-workers/service-worker/navigation-preload/chunked-encoding.https.html

Unfortunately the failure mode of service workers often looks like infra failure. In this case it seems we don't support NavigationPreloadManager so the serviceworker throws an exception and we end up with something that looks like corrupted content in the iframe. Seems like there's a patch for this at https://bugzilla.mozilla.org/show_bug.cgi?id=1564235 but no activity for 5 months, so idk what's happening there.

Comment 3

[Jens Stutte [:jstutte]]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #0)

These fall into a few buckets and I would be ok splitting these into separate bugs if that is easier.

Can you elaborate a bit more on the suspected buckets? I would also like to see more actionable pieces (we might want to keep this as meta bug?) I can nag the team with.

(In reply to James Graham [:jgraham] from comment #2)

/service-workers/service-worker/navigation-preload/request-headers.https.html
/service-workers/service-worker/navigation-preload/chunked-encoding.https.html

In this case it seems we don't support NavigationPreloadManager so the serviceworker throws an exception and we end up with something that looks like corrupted content in the iframe.

I assume, this is one of those buckets and creating a separate bug that depends on bug 1564235 might help here to clarify the status.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

I tried to break it down in the original comment with: clear-site-data, "post loopback messages timeout", and what is now 'navigation-preload' which isn't supported (we can mark the navigation-preload tests as 'backlog' so they are still active, synchronized, run- just as tier-2 on m-c until they are supported).

The last bucket is:
/service-workers/service-worker/clients-matchall-frozen.https.html:
fails with JavaScript error: https://web-platform.test:8443/resources/testdriver.js, line 433: Error: unimplemented

I suspect that is a question for :jgraham.

Comment 5

[James Graham [:jgraham]]

/service-workers/service-worker/clients-matchall-frozen.https.html:

Argh. Google have added something nonstandard here. I'm going to take it up with them, but in the meantime please feel free to disable the test.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1636178 - disable non standard test case, mark navigation-preload tests as backlog. r=jgraham

disable non standard test case, mark navigation-preload tests as backlog.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

what is not covered in the above patch are these 8 tests:
/service-workers/service-worker/client-navigate.https.html
/service-workers/service-worker/fetch-request-css-images.https.html
/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https.html
/service-workers/service-worker/ServiceWorkerGlobalScope/postmessage.https.html
/service-workers/service-worker/unregister-immediately-before-installed.https.html
/service-workers/service-worker/unregister-immediately-during-extendable-events.https.html
/service-workers/service-worker/unregister-immediately.https.html
/service-workers/service-worker/update-after-navigation-redirect.https.html

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8871282af366
disable non standard test case, mark navigation-preload tests as backlog. r=jgraham

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8871282af366