Closed Bug 1636185 Opened 7 months ago Closed 6 months ago

Setting signaled remote video ssrcs fails

Categories

(Core :: WebRTC: Signaling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox-esr68 --- wontfix
firefox75 --- wontfix
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- fixed

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(3 files)

We're failing here on the initial negotiation every time: https://searchfox.org/mozilla-central/rev/dc4560dcaafd79375b9411fdbbaaebb0a59a93ac/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp#993

On the bright side, this means we've really been exercising the ssrc-switching code.

Not sure if we're seeing a similar failure for audio.

Summary: Setting signaled remote ssrcs fails → Setting signaled remote video ssrcs fails

Interesting. Seeing failures on dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html, but only on Linux 18.04 x64 QuantumRender opt, and not on any of the other simulcast tests...

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(docfaraday)

Seems like running the failing test in isolation works fine. Still trying to figure out what is going on here.

Flags: needinfo?(docfaraday)

This test was flaky because until we set a rid filter, all ssrcs were being
received. This meant that the resolution could have been consistent with any of
foo, bar, or baz when we started looking for resize events. In some cases, that
meant that we would never see the resize event for the transition to bar,
because the video element was already at that resolution.

Depends on D74279

Try looks good.

Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a50daa9ee769
Don't use GetRemoteSSRCLocked when setting/unsetting ssrcs, because that is intended to be used for stats, not configuration. r=dminor
https://hg.mozilla.org/integration/autoland/rev/c0aab9a91e21
Inline this since nothing else was using it. r=dminor
https://hg.mozilla.org/integration/autoland/rev/b38d112a2d6a
Don't start emitting frames until we can set our initial RID filter. r=jib

The patch landed in nightly and beta is affected.
:bwc, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(docfaraday)

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #20)

The patch landed in nightly and beta is affected.
:bwc, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

We aren't even sure if this was causing problems in practice, so I don't think we want to uplift this right now. The test case fix might be worth uplifting if that test misbehaves on beta though.

You need to log in before you can comment on or make changes to this bug.