Setting signaled remote video ssrcs fails
Categories
(Core :: WebRTC: Signaling, defect, P2)
Tracking
()
People
(Reporter: bwc, Assigned: bwc)
Details
Attachments
(3 files)
We're failing here on the initial negotiation every time: https://searchfox.org/mozilla-central/rev/dc4560dcaafd79375b9411fdbbaaebb0a59a93ac/media/webrtc/signaling/src/media-conduit/VideoConduit.cpp#993
On the bright side, this means we've really been exercising the ssrc-switching code.
Not sure if we're seeing a similar failure for audio.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
Depends on D74267
Assignee | ||
Comment 3•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=16965707cdd92bb3bf6088db720c7f5afa45f3fd
Assignee | ||
Comment 4•4 years ago
|
||
Interesting. Seeing failures on dom/media/tests/mochitest/test_peerConnection_simulcastOddResolution.html, but only on Linux 18.04 x64 QuantumRender opt, and not on any of the other simulcast tests...
Updated•4 years ago
|
Comment 5•4 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 6•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e852edc86096ac608ab657a6d17f09f3e1d94ffa
Assignee | ||
Comment 7•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31987eb209be85f43019e7e02d7b8a065a2de095
Assignee | ||
Comment 8•4 years ago
|
||
Seems like running the failing test in isolation works fine. Still trying to figure out what is going on here.
Assignee | ||
Comment 9•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8ed538f74a45e3c2e063e71093e4a015205d9de
Assignee | ||
Comment 10•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3f4cdef270aff1c22c1b5cfae68b8758aa52af5
Assignee | ||
Comment 11•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b10308baa84534f3f9e668ddab33d844581c8db6
Assignee | ||
Comment 12•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6963acbc364976dee1b97a538bc6c28daf99a31
Assignee | ||
Comment 13•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=255727de5682dff2b4d305312c7296ca786be875
Assignee | ||
Comment 14•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4de2b1d68803d0eec5d45889dc92f4b7974ed92
Assignee | ||
Comment 15•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0640cfe81d7385524234116cb99893b49994d1e8
Assignee | ||
Comment 16•4 years ago
|
||
This test was flaky because until we set a rid filter, all ssrcs were being
received. This meant that the resolution could have been consistent with any of
foo, bar, or baz when we started looking for resize events. In some cases, that
meant that we would never see the resize event for the transition to bar,
because the video element was already at that resolution.
Depends on D74279
Assignee | ||
Comment 17•4 years ago
|
||
Try looks good.
Comment 18•4 years ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a50daa9ee769 Don't use GetRemoteSSRCLocked when setting/unsetting ssrcs, because that is intended to be used for stats, not configuration. r=dminor https://hg.mozilla.org/integration/autoland/rev/c0aab9a91e21 Inline this since nothing else was using it. r=dminor https://hg.mozilla.org/integration/autoland/rev/b38d112a2d6a Don't start emitting frames until we can set our initial RID filter. r=jib
Comment 19•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a50daa9ee769
https://hg.mozilla.org/mozilla-central/rev/c0aab9a91e21
https://hg.mozilla.org/mozilla-central/rev/b38d112a2d6a
Comment 20•4 years ago
|
||
The patch landed in nightly and beta is affected.
:bwc, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Comment 21•4 years ago
|
||
(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #20)
The patch landed in nightly and beta is affected.
:bwc, is this bug important enough to require an uplift?
If not please setstatus_beta
towontfix
.For more information, please visit auto_nag documentation.
We aren't even sure if this was causing problems in practice, so I don't think we want to uplift this right now. The test case fix might be worth uplifting if that test misbehaves on beta though.
Description
•