Closed
Bug 1636265
Opened 5 years ago
Closed 5 years ago
The switch to Python 3 broke the Eclipse CDT project generating build backend
Categories
(Firefox Build System :: General, defect, P3)
Firefox Build System
General
Tracking
(firefox-esr68 unaffected, firefox75 unaffected, firefox76 unaffected, firefox77 unaffected, firefox78 fixed)
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox75 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | --- | unaffected |
| firefox78 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
(Keywords: regression)
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
Python 3 doesn't allow strings to be written to files opened in binary mode
(it requires a byte array in that case). As it happens, we should really be
opening these Eclipse config files in text mode since it seems on Windows the
files use Windows line ending characters. So rather than change the strings
to byte arrays, this patch simply changes the code to open the files in text
mode.
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/14d0cb2955bf
Fix the Eclipse CDT build backend (broken by the switch to Python 3). r=botond
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
|
||
Updated•5 years ago
|
status-firefox75:
--- → unaffected
status-firefox76:
--- → unaffected
status-firefox77:
--- → unaffected
status-firefox-esr68:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•