1636298 - [css-multicol][css-grid][css-flexbox] Investigate adding a CSS 'column-rule-image-source' property

Status: RESOLVED DUPLICATE of bug 1725495

(Core :: Layout, enhancement, P4)

Description

[Mats Palmgren (inactive)]

Attachment: column-rule-image-source hack

Based on the discussion in https://github.com/w3c/csswg-drafts/issues/2748 about adding more advanced options for styling gutters/gaps for grid/flexbox, it seems to me that column-rule-*could be used for this (assuming that we add corresponding row-rule-* properties). It appears that there is demand for supporting images though, akin to border-image.

In this patch I added a column-rule-image-source property to experiment with this a bit. It doesn't seem to work for some reason though and I can't figure out why... The CreateBorderImageRenderer/CreateWebRenderCommands calls return success and I've verified that I call AssociateRequestToFrame on the right frame in nsFrame::DidSetComputedStyle (however the imgIRequest::imageStatus appears to be STATUS_NONE at that point, which emilio said was unexpected).

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I think this is about the border-image code. You're setting border-width on nsColumnSetFrame::CreateBorderImageRenderers, but not border-style.

I can get it to render multipe things by using a combination of border-width / border-image-width / border-image-repeat / etc.

Comment 2

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 3

[Mats Palmgren (inactive)]

Attachment: Screen capture of rendering above Testcase

Comment 4

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 5

[Mats Palmgren (inactive)]

Attachment: Screen capture of rendering above Testcase

Comment 6

[Daniel Holbert [:dholbert]]

This is subsumed by bug 1725495 now.