Closed Bug 1636310 Opened 3 months ago Closed 3 months ago

[wpt-sync] Sync PR 23469 - [AspectRatio] Handle min-block-size: auto for aspect ratio

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23469 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23469
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

[AspectRatio] Handle min-block-size: auto for aspect ratio

For the default min-height/width, aspect-ratio should only be the minimum
size, and the resulting block size should grow to fit all the content:
https://drafts.csswg.org/css-sizing-4/#aspect-ratio-minimum

Bug: 1045668
Change-Id: I06385087d778e7f05e7097dc25d6858397d0c0e1
Reviewed-on: https://chromium-review.googlesource.com/2186076
WPT-Export-Revision: c3bd42fd09c5bdca89b168ef0d5fa1c01934e930

PR 23469 applied with additional changes from upstream: 4ed544ba95fa011524d36e0b21e88994dac55319
Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 85 tests

Status Summary

Firefox

OK : 2
PASS: 3[GitHub] 74[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 11

Chrome

OK : 2
PASS: 4
FAIL: 10

Safari

OK : 2
PASS: 4
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-sizing/aspect-ratio/quirks-mode-003.tentative.html
body height should match documentElement due to min-height: auto: FAIL

New Tests That Don't Pass

/css/css-sizing/aspect-ratio/percentage-resolution-002.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/block-aspect-ratio-010.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/block-aspect-ratio-012.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/percentage-resolution-001.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/block-aspect-ratio-013.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/percentage-resolution-003.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/quirks-mode-003.tentative.html
body height should match documentElement due to min-height: auto: FAIL (Chrome: PASS, Safari: PASS)
/css/css-sizing/aspect-ratio/block-aspect-ratio-011.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/flex-aspect-ratio-007.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/quirks-mode-001.tentative.html
body height is 100: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/percentage-resolution-004.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c958b21b4327
[wpt PR 23469] - [AspectRatio] Handle min-block-size: auto for aspect ratio, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1507bec4555a
[wpt PR 23469] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5744cac34dd5
[wpt PR 23469] - [AspectRatio] Handle min-block-size: auto for aspect ratio, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2b05123fd17f
[wpt PR 23469] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.