1636342 - TypeError: join() argument must be str or bytes, not 'PositiveOptionValue'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Passing --cache-file to configure fails with:

 0:06.41 Traceback (most recent call last):
 0:06.41   File "/tmp/gecko/configure.py", line 181, in <module>
 0:06.41     sys.exit(main(sys.argv))
 0:06.41   File "/tmp/gecko/configure.py", line 52, in main
 0:06.41     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
 0:06.41   File "/tmp/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 498, in run
 0:06.41     func(*args)
 0:06.41   File "/tmp/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 542, in _value_for
 0:06.41     return self._value_for_depends(obj)
 0:06.41   File "/tmp/gecko/python/mozbuild/mozbuild/util.py", line 1018, in method_call
 0:06.41     cache[args] = self.func(instance, *args)
 0:06.41   File "/tmp/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 551, in _value_for_depends
 0:06.41     value = obj.result()
 0:06.41   File "/tmp/gecko/python/mozbuild/mozbuild/util.py", line 1018, in method_call
 0:06.41     cache[args] = self.func(instance, *args)
 0:06.41   File "/tmp/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 155, in result
 0:06.41     return self._func(*resolved_args)
 0:06.41   File "/tmp/gecko/python/mozbuild/mozbuild/configure/__init__.py", line 1161, in wrapped
 0:06.41     return new_func(*args, **kwargs)
 0:06.41   File "/tmp/gecko/js/sub.configure", line 123, in js_subconfigure
 0:06.41     cache_file = os.path.join(build_env.topobjdir, cache_file)
 0:06.41   File "/tmp/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/lib/python3.7/posixpath.py", line 94, in join
 0:06.41     genericpath._check_arg_types('join', a, *p)
 0:06.41   File "/tmp/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/init_py3/lib/python3.7/genericpath.py", line 149, in _check_arg_types
 0:06.41     (funcname, s.__class__.__name__)) from None
 0:06.41 TypeError: join() argument must be str or bytes, not 'PositiveOptionValue'

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1636342 - Fix configure --cache-file.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75864b70a323
Fix configure --cache-file. r=froydnj

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/75864b70a323