[wpt-sync] Sync PR 23472 - [idle] Replace stop() with an AbortSignal
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox78 fixed)
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 23472 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/23472
Details from upstream follow.
Reilly Grant <reillyg@chromium.org> wrote:
[idle] Replace stop() with an AbortSignal
This change replaces the stop() method on IdleDetector with an
AbortSignal provided as an argument to start(). To allow the detector to
be started multiple times the options are now always passed to start()
rather than the constructor. New options replace previously configured
options if specified.Explainer PR: https://github.com/WICG/idle-detection/issues/19
Bug: 878979
Change-Id: I26418cc3c08a02d77483b7d1b6744c16c17efd08
Reviewed-on: https://chromium-review.googlesource.com/2189631
WPT-Export-Revision: ece18e244abdc286df1c2fe20d21db88010b3914
Assignee | ||
Comment 1•3 years ago
|
||
PR 23472 applied with additional changes from upstream: 6d1a21bee19885b49dddb5cd234beea4e162b306, d567a81805f4614a0a4d295bee11e9fee99aa219
Assignee | ||
Comment 2•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=960393f54de6df075ac6534fa0e5f7813daab1f4
Assignee | ||
Comment 3•3 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 75 tests
Status Summary
Firefox
OK : 2
PASS : 71
FAIL : 2
ERROR : 2
NOTRUN: 12
Chrome
OK : 3
PASS : 63
FAIL : 7
ERROR : 1
Safari
OK : 2
FAIL : 2
ERROR : 2
NOTRUN: 12
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/idle-detection/basics.tentative.https.window.html: ERROR [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: OK, Safari: ERROR)
start() rejects with invalid threshold (NaN): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() rejects with invalid threshold (-1): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() allows threshold (61000): NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() uses a default value for the threshold: NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() rejects with threshold below minimum (59000): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() uses a default value for the threshold when none is passed: NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() rejects with invalid threshold (null): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() uses threshold property: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() rejects with invalid threshold (0): NOTRUN (Chrome: FAIL, Safari: NOTRUN)
start() basics: NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() rejects threshold (60000): NOTRUN (Chrome: PASS, Safari: NOTRUN)
start() uses signal property: NOTRUN (Chrome: FAIL, Safari: NOTRUN)
/idle-detection/idlharness-worker.https.window.html: OK [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: OK, Safari: OK)
Run idlharness tests in a worker.: FAIL (Chrome: PASS, Safari: FAIL)
/idle-detection/interceptor.https.html: ERROR [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: ERROR, Safari: ERROR)
/idle-detection/idlharness.https.window.html: OK [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: OK, Safari: OK)
Test IDL implementation of Idle Detection API: FAIL (Chrome: PASS, Safari: FAIL)
Tests Disabled in Gecko Infrastructure
/idle-detection/basics.tentative.https.window.html: ERROR [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: OK, Safari: ERROR)
/idle-detection/idlharness-worker.https.window.html: OK [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: OK, Safari: OK)
/idle-detection/interceptor.https.html: ERROR [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: ERROR, Safari: ERROR)
/idle-detection/idlharness.https.window.html: OK [GitHub
], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview
, Gecko-android-em-7.0-x86_64-opt-geckoview
, Gecko-linux1804-64-debug
, Gecko-linux1804-64-opt
, Gecko-linux1804-64-qr-debug
, Gecko-linux1804-64-qr-opt
, Gecko-windows10-64-debug
, Gecko-windows10-64-opt
, Gecko-windows10-64-qr-debug
, Gecko-windows10-64-qr-opt
, Gecko-windows7-32-debug
, Gecko-windows7-32-opt
] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89945c20767c [wpt PR 23472] - [idle] Replace stop() with an AbortSignal, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ff5e06c6a79 [wpt PR 23472] - [idle] Replace stop() with an AbortSignal, a=testonly
Comment 6•3 years ago
|
||
bugherder |
Description
•