1636385 - Netmonitor blocking - Set context menu options to disabled_status if all options are Enabled or Disabled already

Status: VERIFIED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot 0002-05-08 at 10.42.45.png

Affected versions

• 77.0b2, 78.0a1(2020-05-07);

Affected platforms

• Windows 10, macOS 10.15.3, Ubuntu 18.04;

Steps to reproduce

1. Launch Firefox, DevTools, Netmonitor tab;
2. Access any webpage, in the Netmonitor tab enable the Request Blocking panel;
3. Add any filters to start blocking(at least 2 ;
4. Right click over any added filter in the list;
5. Click on the Enable all option;

Expected result / Enhancement sugestion

• option is disabled-unclickable;

Actual result

• option is enabled-clickable;

Regression range

• not a regression, followup from 1588076; would make the use-flow more consistent across the browser.

Additional info

• attached screenshot the better illustrate the issue;
• same scenario would be for the [Disable all] option when they're disabled already;

Comment 1

[Kriyszig]

I would like to take this up if no one is working on it already
Thank you

Comment 2

[Hubert Boma Manilla (:bomsy)]

Assigned to you. Thanks

Comment 3

[Kriyszig]

Attachment: Bug 1636385 - Disable context menu options if blocking is enabled/disabled for all URL in Network Blocking Panel r=bomsy

The context menu of the network blocking panel have options to
"Enable all" and "Disable all" for enabling and disbaling all the
patters in the request blocking panel at once.
This patch disables those options in case all the URLs are already
enabled or disabled. Having the buttons active all the time might
lead to confusing situtaions especially with long blocking pattern
list where it may lead the user to think there is a URL that has not
been enabled/disabled eve after clicking the menu option.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09b7ee5e868b
Disable context menu options if blocking is enabled/disabled for all URL in Network Blocking Panel r=bomsy

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/09b7ee5e868b

Comment 6

[Cristian Fogel [:cfogel]]

Verified with 78.0a1 (2020-05-26) on macOS 10.15.3., Ubuntu 16, Windows 10.