Closed Bug 1636398 Opened 4 years ago Closed 4 years ago

Intermittent tools/profiler/tests/browser/browser_test_feature_preferencereads.js | PreferenceRead profile markers for layout.css.dpi were recorded when the PreferenceRead feature was turned on. - 0 > 0 - JS frame

Categories

(Core :: Gecko Profiler, defect, P5)

Product:
Core
Component:
Gecko Profiler
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mozbugz)

References

(Regression)

Details

(Keywords: intermittent-failure, regression, Whiteboard: [retriggered])

Attachments

(1 file)

Bug 1636398 - Tweak default profiler buffer size in tests - r?canaltinova
47 bytes, text/x-phabricator-request
Details | Review

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=301383446&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Hjo0kSomQ2u8J8NQ1E1ZQQ/runs/0/artifacts/public/logs/live_backing.log

[task 2020-05-08T08:57:02.926Z] 08:57:02 INFO - TEST-PASS | tools/profiler/tests/browser/browser_test_feature_preferencereads.js | The profiler is not currently active - true == true -
[task 2020-05-08T08:57:02.927Z] 08:57:02 INFO - Buffered messages finished
[task 2020-05-08T08:57:02.927Z] 08:57:02 INFO - TEST-UNEXPECTED-FAIL | tools/profiler/tests/browser/browser_test_feature_preferencereads.js | PreferenceRead profile markers for layout.css.dpi were recorded when the PreferenceRead feature was turned on. - 0 > 0 - JS frame :: chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_feature_preferencereads.js :: test_profile_feature_preferencereads/< :: line 65
[task 2020-05-08T08:57:02.927Z] 08:57:02 INFO - Stack trace:
[task 2020-05-08T08:57:02.927Z] 08:57:02 INFO - chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_feature_preferencereads.js:test_profile_feature_preferencereads/<:65
[task 2020-05-08T08:57:02.927Z] 08:57:02 INFO - resource://testing-common/BrowserTestUtils.jsm:withNewTab:146
[task 2020-05-08T08:57:02.928Z] 08:57:02 INFO - chrome://mochitests/content/browser/tools/profiler/tests/browser/browser_test_feature_preferencereads.js:test_profile_feature_preferencereads:49
[task 2020-05-08T08:57:02.928Z] 08:57:02 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1064
[task 2020-05-08T08:57:02.928Z] 08:57:02 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1104
[task 2020-05-08T08:57:02.928Z] 08:57:02 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:927
[task 2020-05-08T08:57:02.928Z] 08:57:02 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-05-08T08:57:02.928Z] 08:57:02 INFO - GECKO(12423) | [Parent 12423, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.928Z] 08:57:02 INFO - GECKO(12423) | [Child 12593, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.929Z] 08:57:02 INFO - GECKO(12423) | [Child 12965, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.930Z] 08:57:02 INFO - GECKO(12423) | [Child 12609, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.931Z] 08:57:02 INFO - GECKO(12423) | [Child 13032, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.931Z] 08:57:02 INFO - GECKO(12423) | [Child 12679, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.932Z] 08:57:02 INFO - GECKO(12423) | [Child 12704, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.933Z] 08:57:02 INFO - GECKO(12423) | [Child 12803, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.933Z] 08:57:02 INFO - GECKO(12423) | [Child 13009, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:02.933Z] 08:57:02 INFO - GECKO(12423) | [Child 12903, ProfilerChild] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp, line 225
[task 2020-05-08T08:57:03.800Z] 08:57:03 INFO - GECKO(12423) | [Child 13009: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x7fda45378c00) [pid = 13009] [serial = 4] [outer = 0x7fda6f393350]
[task 2020-05-08T08:57:07.419Z] 08:57:07 INFO - TEST-PASS | tools/profiler/tests/browser/browser_test_feature_preferencereads.js | No PreferenceRead profile markers for layout.css.dpi were recorded when the PreferenceRead feature was turned on. - 0 == 0 -
[task 2020-05-08T08:57:07.420Z] 08:57:07 INFO - TEST-PASS | tools/profiler/tests/browser/browser_test_feature_preferencereads.js | No PreferenceRead profile markers for layout.css.dpi were recorded when the PreferenceRead feature was turned on. - 0 == 0 -
[task 2020-05-08T08:57:07.464Z] 08:57:07 INFO - Leaving test bound test_profile_feature_preferencereads

Has Regression Range: --- → yes
Keywords: regression

I can't think of an obvious link between that push and the error. Investigating...

Assignee: nobody → gsquelart
Flags: needinfo?(gsquelart)

A too-small buffer size is the link! Because of bug 1632750, the "entries" settings now applies to all of Firefox instead of each thread.
This test (and others like browser_test_feature_jsallocations.js) rely on capturing enough data to verify that the expected information is there; but if the buffer is too small, that information could be destroyed too soon.

I will set a higher default size, to match the tweaks in https://hg.mozilla.org/mozilla-central/rev/037361148517
This should also fix bug 1636556.

Blocks: 1636556

Also removed explicit size in test_feature_nativeallocations, as we want a reasonably-big buffer in this tests.

Other tests with small buffer sizes are fine, since the profiler imposes a minimum size that should be big enough to capture at least 8 large stacks (see bug 1571171).

Set release status flags based on info from the regressing bug 1632750

status-firefox76: --- → unaffected
status-firefox77: --- → unaffected
status-firefox78: --- → affected
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/03f0e0e886f3
Tweak default profiler buffer size in tests - r=canaltinova

https://hg.mozilla.org/mozilla-central/rev/03f0e0e886f3

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: