1636420 - Connect SSE actor to the Message panel

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

As soon as we have EventSourceActor (bug 1636417) we can connect that to the existing message panel UI.

The connection should happen at the same place as for WS:
https://searchfox.org/mozilla-central/rev/dc4560dcaafd79375b9411fdbbaaebb0a59a93ac/devtools/client/netmonitor/src/connector/firefox-connector.js#170

The work includes:

• Front end for SSE actor
• Data provider changes
• Firefox connector changes

Honza

Comment 1

[Farooq AR]

Attachment: Bug 1636420 - Connect SSE actor to the Message panel. r=Honza,bomsy

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4208dfc006f
Connect SSE actor to the Message panel. r=Honza,bomsy

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset e4208dfc006f (bug 1636420) for test_protocol_index.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=b818588404a55e3cffab3e672ef01ae708d00567&searchStr=xpc&tochange=e8397f7197a11bd5b6d86cabaeadb45abbfb2440&selectedTaskRun=Tovo_PKGQcqbvD9KT-7nyg-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/e8397f7197a11bd5b6d86cabaeadb45abbfb2440

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302896650&repo=autoland&lineNumber=3228

task 2020-05-19T12:46:28.011Z] 12:46:28     INFO -  TEST-START | devtools/shared/protocol/tests/xpcshell/test_protocol_index.js
[task 2020-05-19T12:46:28.390Z] 12:46:28  WARNING -  TEST-UNEXPECTED-FAIL | devtools/shared/protocol/tests/xpcshell/test_protocol_index.js | xpcshell return code: 0
[task 2020-05-19T12:46:28.391Z] 12:46:28     INFO -  TEST-INFO took 372ms
[task 2020-05-19T12:46:28.391Z] 12:46:28     INFO -  >>>>>>>
[task 2020-05-19T12:46:28.391Z] 12:46:28     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-05-19T12:46:28.391Z] 12:46:28  WARNING -  TEST-UNEXPECTED-FAIL | devtools/shared/protocol/tests/xpcshell/test_protocol_index.js | test_index_is_alphabetically_sorted - [test_index_is_alphabetically_sorted : 22] Spec definition for "devtools/shared/specs/eventsource" should be before "devtools/shared/specs/websocket" - false == true
[task 2020-05-19T12:46:28.391Z] 12:46:28     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/devtools/shared/protocol/tests/xpcshell/test_protocol_index.js:test_index_is_alphabetically_sorted:22
[task 2020-05-19T12:46:28.391Z] 12:46:28     INFO -  /builds/worker/workspace/build/tests/xpcshell/tests/devtools/shared/protocol/tests/xpcshell/test_protocol_index.js:run_test:10
[task 2020-05-19T12:46:28.392Z] 12:46:28     INFO -  /builds/worker/workspace/build/tests/xpcshell/head.js:_execute_test:565
[task 2020-05-19T12:46:28.392Z] 12:46:28     INFO -  -e:null:1
[task 2020-05-19T12:46:28.392Z] 12:46:28     INFO -  exiting test
[task 2020-05-19T12:46:28.392Z] 12:46:28     INFO -  <<<<<<<
[task 2020-05-19T12:46:28.392Z] 12:46:28     INFO -  INFO | Result summary:
[task 2020-05-19T12:46:28.392Z] 12:46:28     INFO -  INFO | Passed: 828
[task 2020-05-19T12:46:28.392Z] 12:46:28  WARNING -  INFO | Failed: 1
[task 2020-05-19T12:46:28.392Z] 12:46:28  WARNING -  One or more unittests failed.
[task 2020-05-19T12:46:28.392Z] 12:46:28     INFO -  INFO | Todo: 0
[task 2020-05-19T12:46:28.393Z] 12:46:28     INFO -  INFO | Retried: 2
[task 2020-05-19T12:46:28.393Z] 12:46:28     INFO -  SUITE-END | took 1003s
[task 2020-05-19T12:46:28.393Z] 12:46:28     INFO -  Node moz-http2 server shutting down ...
[task 2020-05-19T12:46:28.469Z] 12:46:28    ERROR - Return code: 1
[task 2020-05-19T12:46:28.470Z] 12:46:28     INFO - TinderboxPrint: xpcshell-xpcshell<br/>828/<em class="testfail">1</em>/0
[task 2020-05-19T12:46:28.470Z] 12:46:28  WARNING - # TBPL FAILURE #
[task 2020-05-19T12:46:28.470Z] 12:46:28  WARNING - setting return code to 2
[task 2020-05-19T12:46:28.470Z] 12:46:28  WARNING - The xpcshell suite: xpcshell ran with return status: FAILURE

Comment 4

[Farooq AR]

Updated the patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9466e4962dba
Connect SSE actor to the Message panel. r=Honza,bomsy

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9466e4962dba