1636463 - Refactor ASRouter to use SpecialMessageActions

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Kate Hudson :k88hudson]

In Bug 1633368, we're refactoring special message actions to be usable externally, including by about welcome.

In this bug we can remove the handleUserAction function: https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/ASRouter.jsm#1928 and use this module instead

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Bug 1636463 - Refactor ASRouter to use SpecialMessageActions

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2dd9568a9044
Refactor ASRouter to use SpecialMessageActions r=k88hudson

Comment 3

[Razvan Maries]

Backed out for perma failures on browser_asrouter_cfr.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=TnJ17h5oSfCVvBCwddnYGg-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=2dd9568a90442602f449ffdc1bce6926de7765d1

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303105229&repo=autoland&lineNumber=2789

Backout: https://hg.mozilla.org/integration/autoland/rev/8ee537e6b4b8807fe8b7992b2586951690f47a0e

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/250ab0b9289e
Refactor ASRouter to use SpecialMessageActions r=k88hudson

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/250ab0b9289e