1636628 - update vendored libprio to 1.6

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P3)

Description

[Robert Helmer [:rhelmer]]

libprio 1.6 is out, here are the changes since last import:

commit 52643cefe6662b4099e16a40a057cb60651ab001
Author: Robert Helmer <[e-mail]>
Date: Sun Apr 26 12:23:09 2020 -0700

upgrade Travis CI distro to Ubuntu Bionic (#86)

commit f72b2b244194b4d13bb0b68f163591bc16eae55d
Author: Henry Corrigan-Gibbs <[e-mail]>
Date: Tue Apr 21 19:14:17 2020 +0200

Fix serialization bug in `prio/serial.c` (#81)

* In `serial_read_packet_client`, we should check that the type
of the incoming packet matches the type of the `PrioPacketClient`
passed into `serial_read_packet_client` and fail if the two don't
match.

* Add a test for this behavior.

Co-authored-by: Robert Helmer <[e-mail]>

commit ed4142ae1cec2082d5efb0f7429cad4b77af672c
Author: Christian Holler (:decoder) <[e-mail]>
Date: Tue Apr 21 19:07:56 2020 +0200

Fix memory leak in serial_read_packet_client (#80)

* Fix memory leak in serial_read_packet_client

* Fixing more memory leaks in `prio/serial.c`

The `UP_CHECK` macro just returned on failure, rather than
jumping to the `cleanup` label. This commit replaces `UP_CHECK`
with `UP_CHECKC`, which jumps to `cleanup` on failure.

* Replace `P_CHECK` with `P_CHECKC` in prio/serial.c

Every function in `prio/serial.c` has a `cleanup` label, but
much of the code in these functions won't actually jump to
cleanup on failure. As far as I can tell, this doesn't cause
any additional memory leaks, but in case someone adds cleanup
code at the `cleanup` label in the future, it seems prudent to
always jump to `cleanup` on failure.

Co-authored-by: Henry Corrigan-Gibbs <[e-mail]>

commit 6efb51c538658828e1a7be42cb3e4b6caba41c46
Author: tititiou36 <[e-mail]>
Date: Sun Apr 19 12:15:31 2020 +0200

No need to memset memory allocated with calloc

commit 9a30c743c0e6d67773ec8341b7e59b69029d0dd1
Author: Gabriel Ganne <[e-mail]>
Date: Wed Aug 7 16:12:05 2019 +0200

remove unnecessary runtime call to strlen()

PRIO_TAG is a fixed-size string, we can use sizeof to the same effect.
This also has the nice side-effect of removing a variable-length-array
since AAD_LEN could not be known at compile-time

commit 854d87d8a15ba6275e76d8b06140839f3c1d3475
Author: Anthony Miyaguchi <[e-mail]>
Date: Tue Apr 30 14:44:59 2019 -0700

Update SConstruct to modify include path based on sys.platform (#74)

* Format SConstruct with black

* Update SConstruct to modify include path based on OS

* Remove unneeded exports

commit 662191a831fa6ea38460d51e4be5ba84dfaec247
Author: Henry Corrigan-Gibbs <[e-mail]>
Date: Sat Mar 30 08:57:09 2019 -0700

Remove comment in CODE_OF_CONDUCT.md

commit bbca24fded07fa65451dec8b7a406d27890395cf
Author: Mozilla-GitHub-Standards <[e-mail]>
Date: Fri Mar 29 23:57:03 2019 -0700

Add Mozilla Code of Conduct file

Fixes #72.

_(Message COC002)_

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: Bug 1636628 - update vendored libprio to 1.5 r=glandium

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:rhelmer, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c339f8c535e
update vendored libprio to 1.5 r=glandium

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7c339f8c535e