1636634 - Cannot close RDM with reloadConditions enabled.

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Micah [:mtigley] (she/her)]

Reproducible in Firefox Developer Edition 77.0b3 (64-bit) version.

STR

1. Ensure that devtools.responsive.reloadConditions.touchSimulation is true and devtools.responsive.browserUI.enabled is false.
2. Open RDM.
3. Try closing RDM.

Expected
RDM closes without issue.

Actual
RDM doesn't close.

The following error is reported in the Browser Console:

Exception when calling onAvailable handler this.getViewportBrowser().reload is not a function TypeError: "this.getViewportBrowser().reload is not a function"
    restoreActorState resource://devtools/client/responsive/ui.js:945
    onTargetAvailable resource://devtools/client/responsive/ui.js:1208
    promises resource://devtools/shared/resources/target-list.js:527
    watchTargets resource://devtools/shared/resources/target-list.js:522
    connectToServer resource://devtools/client/responsive/ui.js:476
    init resource://devtools/client/responsive/ui.js:224
    ResponsiveUI resource://devtools/client/responsive/ui.js:115
    openIfNeeded resource://devtools/client/responsive/manager.js:129
    toggle resource://devtools/client/responsive/manager.js:92
    onKeyShortcut resource://devtools/client/framework/devtools-browser.js:342
    onKey resource:///modules/DevToolsStartup.jsm:876
    xulKey resource:///modules/DevToolsStartup.jsm:798
    createKey resource:///modules/DevToolsStartup.jsm:910
    attachKeys resource:///modules/DevToolsStartup.jsm:798
    hookKeyShortcuts resource:///modules/DevToolsStartup.jsm:777
    onBeforeCreated resource:///modules/DevToolsStartup.jsm:591
    aEventName resource:///modules/CustomizableUI.jsm:2862
    buildWidget resource:///modules/CustomizableUI.jsm:1698
    getWidgetNode resource:///modules/CustomizableUI.jsm:1165
    buildArea resource:///modules/CustomizableUI.jsm:975
    registerToolbarNode resource:///modules/CustomizableUI.jsm:889
    registerToolbarNode resource:///modules/CustomizableUI.jsm:3599
    onDOMContentLoaded chrome://browser/content/browser.js:1794
    EventListener.handleEvent* chrome://browser/content/browser.xhtml:135
target-list.js:536:19
    promises resource://devtools/shared/resources/target-list.js:536
    watchTargets resource://devtools/shared/resources/target-list.js:522
    connectToServer resource://devtools/client/responsive/ui.js:476
    init resource://devtools/client/responsive/ui.js:224
    ResponsiveUI resource://devtools/client/responsive/ui.js:115
    openIfNeeded resource://devtools/client/responsive/manager.js:129
    toggle resource://devtools/client/responsive/manager.js:92
    onKeyShortcut resource://devtools/client/framework/devtools-browser.js:342
    onKey resource:///modules/DevToolsStartup.jsm:876
    xulKey resource:///modules/DevToolsStartup.jsm:798
    (Async: EventListener.handleEvent)
    createKey resource:///modules/DevToolsStartup.jsm:910
    attachKeys resource:///modules/DevToolsStartup.jsm:798
    hookKeyShortcuts resource:///modules/DevToolsStartup.jsm:777
    onBeforeCreated resource:///modules/DevToolsStartup.jsm:591
    aEventName resource:///modules/CustomizableUI.jsm:2862
    buildWidget resource:///modules/CustomizableUI.jsm:1698
    getWidgetNode resource:///modules/CustomizableUI.jsm:1165
    buildArea resource:///modules/CustomizableUI.jsm:975
    registerToolbarNode resource:///modules/CustomizableUI.jsm:889
    registerToolbarNode resource:///modules/CustomizableUI.jsm:3599
    onDOMContentLoaded chrome://browser/content/browser.js:1794
    <anonymous> chrome://browser/content/browser.xhtml:135

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 1636634 - Use BrowsingContextTargetActor's reload method to reload the current tab in RDM

Comment 2

[Micah [:mtigley] (she/her)]

Using mozregression, I narrowed the regression window to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3220c674960139d31143ef7211bf4871f82aa143&tochange=dcbfa257190eb637bda73e6dd111eb6433ddd21f

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1630691

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f0b3cebb114
Use BrowsingContextTargetActor's reload method to reload the current tab in RDM r=jdescottes,bradwerth

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3f0b3cebb114

Comment 6

[Micah [:mtigley] (she/her)]

Comment on attachment 9146985 [details]
Bug 1636634 - Use BrowsingContextTargetActor's reload method to reload the current tab in RDM

Beta/Release Uplift Approval Request

• User impact if declined: User will be unable to close RDM and would have to close the tab itself to get it back to normal.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes to how the tab is reloaded to apply emulated settings in RDM are small.
• String changes made/needed:

Comment 7

[Micah [:mtigley] (she/her)]

Hi Pascal, would we be able to uplift this patch to Firefox Developer Edition? The issue only occurs when "devtools.responsive.browserUI.enabled" is set to false, which is what the Firefox Dev Edition build uses by default.

Comment 8

[Pascal Chevrel:pascalc]

(In reply to Micah Tigley [:mtigley] from comment #7)

Hi Pascal, would we be able to uplift this patch to Firefox Developer Edition? The issue only occurs when "devtools.responsive.browserUI.enabled" is set to false, which is what the Firefox Dev Edition build uses by default.

Developer Edition is built from the beta branch, so that will happen automatically.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9146985 [details]
Bug 1636634 - Use BrowsingContextTargetActor's reload method to reload the current tab in RDM

Low risk, has tests and fixes a dev-edition only devtools bug, , uplift approved for beta 6, thanks.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b17132cf5a25