1636652 - [wpt-sync] Sync PR 23494 - [FlexNG] Change OverrideHeight variant

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23494 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23494
Details from upstream follow.

David Grogan <[e-mail]> wrote:

[FlexNG] Change OverrideHeight variant

In LayoutBox::AvailableLogicalHeightUsing, we were using
OverrideContainingBlockContentLogicalHeight instead of
OverrideContentLogicalHeight for getting the definite height of the flex
item.

Of the new tests, 004.html worked before this fix but it wasn't obvious
that it would.

Bug: 1077524
Change-Id: I2968f8e553476df6fa59c2abb74940eb1467f9cb
Reviewed-on: https://chromium-review.googlesource.com/2191345
WPT-Export-Revision: 2391216a2dccc357685a5931709b11b426db7cbb

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2be30378496c7fd20c205159704f6feda24f5c7b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a78843c7ef14
[wpt PR 23494] - [FlexNG] Change OverrideHeight variant, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06b070586f34
[wpt PR 23494] - [FlexNG] Change OverrideHeight variant, a=testonly

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/06b070586f34