Closed Bug 1636723 Opened 4 years ago Closed 4 years ago

Have nsPrintSettingsX use the NSPrintInfo methods rather than mess with its internal dictionary

Categories

(Core :: Printing: Setup, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Whiteboard: [print2020_v78])

Attachments

(1 file)

No description provided.

It is not obvious that the dict is an internal implementation detail of the
NSPrintInfo, so it was confusing to me that in some places setters are using a
dict but getters are using NSPrintInfo methods. This hopefully makes the code
simpler and easier to understand.

Blocks: 1638143
Attachment #9147066 - Attachment description: Bug 1636723. Have nsPrintSettingsX use the NSPrintInfo methods rather than mess with its internal dictionary. r=spohl,mstange → Bug 1636723. Have nsPrintSettingsX use the NSPrintInfo methods rather than mess with its internal dictionary. r=spohl
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/39826e3d4191
Have nsPrintSettingsX use the NSPrintInfo methods rather than mess with its internal dictionary. r=spohl
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: