Closed Bug 1636798 Opened 1 year ago Closed 1 year ago

Icon in the sources pane does not revert to its original state after closing pretty printed tab

Categories

(DevTools :: Debugger, defect)

78 Branch
defect

Tracking

(firefox78 fixed)

RESOLVED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed

People

(Reporter: kyleknaggs, Assigned: kyleknaggs)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36

Steps to reproduce:

User Agent:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to Reproduce:

  1. Visit https://todomvc-jquery-minified.glitch.me and open the Debugger in the Mozilla Developer Tools.
  2. Navigate to director.js in the Sources pane.
  3. Click on the director.js file so that it opens in the Editor.
  4. Pretty print director.js by right-clicking on the tab name and selecting Pretty Print Source from dropdown menu that appears.
  5. Close the new tab with the formatted code that was created by pretty printing director.js.

Actual results:

Actual Results:
The pretty print icon to the left of the file name in the source pane remains unchanged.

Expected results:

Expected Results:
The icon to the left of the file name in the sources pane should revert to the JavaScript icon that was there prior to the file being pretty printed.

Keywords: good-first-bug

Hello! I know this bug has not been confirmed as yet, but if it is, would it be possible for me to claim it? I think it would be a good first bug.

Sure Kyle, go for it :)

Because this bug's Severity is normal and has not been changed, and this bug's priority is -- (none,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Severity: normal → --

Added a new hasPrettyTab() selector function.
Renamed the function and prop in SourcesTreeItem to reflect the new hasPrettyTab() selector function.
Updated the snapshot test for the pretty print icon.

Assignee: nobody → kyleknaggs
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/101545eb6cba
Check tabs instead of source when displaying pretty print icon r=davidwalsh
Status: UNCONFIRMED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
You need to log in before you can comment on or make changes to this bug.