Closed Bug 1636853 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23498 - Fix computed style for outline-width allowing decimal numbers

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla78
Tracking Flags:
Tracking Status
firefox78 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23498 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23498
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:

Fix computed style for outline-width allowing decimal numbers

Apart from that modified an internal test:
fast/css/round-up-all-line-width-less-than-1-greater-than-0.html
So it actually checks borders too, and removing "pt" values
as the result in pixels might create rounding issues.

BUG=1068107
TEST=external/wpt/css/css-ui/parsing/outline-width-computed.html

Change-Id: I75630b63428fed1dc3fcb91186f059ecddef1e85
Reviewed-on: https://chromium-review.googlesource.com/2192931
WPT-Export-Revision: 4917bf4213110da0dde11bb436c94a98414f2fcf

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 73 tests

Status Summary

Firefox

OK : 2
PASS: 140[GitHub] 211[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 17

Chrome

OK : 2
PASS: 156
FAIL: 1

Safari

OK : 2
PASS: 126
FAIL: 31

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-ui/animation/outline-width-interpolation.html
CSS Animations: property <outline-width> from [unset] to [23px] at (0) should be [3px]: FAIL
Web Animations: property <outline-width> from [unset] to [23px] at (1.5) should be [33px]: FAIL
CSS Animations: property <outline-width> from [initial] to [23px] at (0.6) should be [15px]: FAIL
Web Animations: property <outline-width> from [unset] to [23px] at (0) should be [3px]: FAIL
CSS Animations: property <outline-width> from [unset] to [23px] at (0.6) should be [15px]: FAIL
CSS Animations: property <outline-width> from [initial] to [23px] at (0.3) should be [9px]: FAIL
Web Animations: property <outline-width> from [initial] to [23px] at (0) should be [3px]: FAIL
Web Animations: property <outline-width> from [initial] to [23px] at (0.3) should be [9px]: FAIL
Web Animations: property <outline-width> from [initial] to [23px] at (1.5) should be [33px]: FAIL
CSS Animations: property <outline-width> from [unset] to [23px] at (0.3) should be [9px]: FAIL
Web Animations: property <outline-width> from [unset] to [23px] at (0.3) should be [9px]: FAIL
CSS Animations: property <outline-width> from [unset] to [23px] at (1.5) should be [33px]: FAIL
Web Animations: property <outline-width> from [initial] to [23px] at (0.6) should be [15px]: FAIL
CSS Animations: property <outline-width> from [initial] to [23px] at (0) should be [3px]: FAIL
Web Animations: property <outline-width> from [unset] to [23px] at (0.6) should be [15px]: FAIL
CSS Animations: property <outline-width> from [initial] to [23px] at (1.5) should be [33px]: FAIL

New Tests That Don't Pass

/css/css-ui/animation/outline-width-interpolation.html
CSS Animations: property <outline-width> from [unset] to [23px] at (0) should be [3px]: FAIL (Chrome: PASS, Safari: PASS)
Web Animations: property <outline-width> from [unset] to [23px] at (1.5) should be [33px]: FAIL (Chrome: PASS, Safari: PASS)
CSS Animations: property <outline-width> from [initial] to [23px] at (0.6) should be [15px]: FAIL (Chrome: PASS, Safari: PASS)
Web Animations: property <outline-width> from [unset] to [23px] at (0) should be [3px]: FAIL (Chrome: PASS, Safari: PASS)
CSS Animations: property <outline-width> from [unset] to [23px] at (0.6) should be [15px]: FAIL (Chrome: PASS, Safari: PASS)
CSS Animations: property <outline-width> from [initial] to [23px] at (0.3) should be [9px]: FAIL (Chrome: PASS, Safari: PASS)
Web Animations: property <outline-width> from [initial] to [23px] at (0) should be [3px]: FAIL (Chrome: PASS, Safari: PASS)
Web Animations: property <outline-width> from [initial] to [23px] at (0.3) should be [9px]: FAIL (Chrome: PASS, Safari: PASS)
Web Animations: property <outline-width> from [initial] to [23px] at (1.5) should be [33px]: FAIL (Chrome: PASS, Safari: PASS)
CSS Animations: property <outline-width> from [unset] to [23px] at (0.3) should be [9px]: FAIL (Chrome: PASS, Safari: PASS)
Web Animations: property <outline-width> from [unset] to [23px] at (0.3) should be [9px]: FAIL (Chrome: PASS, Safari: PASS)
CSS Animations: property <outline-width> from [unset] to [23px] at (1.5) should be [33px]: FAIL (Chrome: PASS, Safari: PASS)
Web Animations: property <outline-width> from [initial] to [23px] at (0.6) should be [15px]: FAIL (Chrome: PASS, Safari: PASS)
CSS Animations: property <outline-width> from [initial] to [23px] at (0) should be [3px]: FAIL (Chrome: PASS, Safari: PASS)
Web Animations: property <outline-width> from [unset] to [23px] at (0.6) should be [15px]: FAIL (Chrome: PASS, Safari: PASS)
CSS Animations: property <outline-width> from [initial] to [23px] at (1.5) should be [33px]: FAIL (Chrome: PASS, Safari: PASS)
/css/css-ui/parsing/outline-width-computed.html
Property outline-width value '2.5px': FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/eaaf46684e6b
[wpt PR 23498] - Fix computed style for outline-width allowing decimal numbers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b149189f5709
[wpt PR 23498] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ecacb38cd76
[wpt PR 23498] - Fix computed style for outline-width allowing decimal numbers, a=testonly
https://hg.mozilla.org/integration/autoland/rev/cb9949359a44
[wpt PR 23498] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1ecacb38cd76
https://hg.mozilla.org/mozilla-central/rev/cb9949359a44

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.