1636978 - [wpt-sync] Sync PR 23508 - Attribute animations should not be reflected by getAttribute(...)

Status: RESOLVED FIXED

(Core :: SVG, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23508 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23508
Details from upstream follow.

Fredrik Söderqvist <[e-mail]> wrote:

Attribute animations should not be reflected by getAttribute(...)

According to SMIL [1], when an attribute is animated, the actual DOM
attribute should not change. So only synchronize attributes after a base
value change has taken place.
Rename related flags and methods to not include "animated", since that
seems a bit misleading.
Add SVGElement::CollectStyleForAnimatedPresentationAttributes() to
handle animations of attributes that are presentation attributes but are
not actually specified on the target element.

[1] https://www.w3.org/TR/2001/REC-smil-animation-20010904/#BasicAnim

Bug: 735820
Change-Id: I2a0858dd383a1a96e7b96451a6fca07084983d57
Reviewed-on: https://chromium-review.googlesource.com/2173184
WPT-Export-Revision: 438ef7cdc3099f84542281e5d4f3634ee4e0c21f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c431ab5c9e99aa8b609ef1c7598463991effc298

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 72 tests

Status Summary

Firefox

OK : 1
PASS: 1[GitHub] 72[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/525bb6234d13
[wpt PR 23508] - Attribute animations should not be reflected by getAttribute(...), a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bfff3fc5ef6
[wpt PR 23508] - Attribute animations should not be reflected by getAttribute(...), a=testonly

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/6bfff3fc5ef6