1636994 - allow in private browsing panel does not work in perma-private browsing

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[kernp25]

Attachment: firefox_vlsOtXqskr.png

I saw this TypeError in the browser console: can't access property "checked", checkbox is null

My browser version: 78.0a1 (2020-05-10) (64-Bit)

Comment 1

[kernp25]

Attachment: firefox_sWKCnhQ4bX.png

Comment 2

[kernp25]

It seems to happen, after you install an add-on.

e.g. https://addons.mozilla.org/firefox/addon/impero-education-prov204/?src=recommended

Comment 3

[kernp25]

Can you confirm this bug?

Comment 4

[Tomislav Jovanovic :zombie]

Please don't need-info people unless you have a specific question for a person or an urgent problem. We triage bugs on a weekly basis, and will look into them in due time.

Comment 5

[kernp25]

Attachment: ACkQFbwPDa.png

This dialog will not show when installing an add-on.

Comment 6

[Victor Carciu]

I can reproduce this issue on FF78.0a1 (2020-05-19) and I can also confirm that the checkbox popup "Allow this extension to run in Private Window" is not displayed anymore on the top right side of the screen when installing a new extension.

The error message from browser console is exactly the one attached in the initial screenshot :

"TypeError: can't access property "checked", checkbox is null"

I will also attach a video with the issue and I will try a bisection in order to provide the regression range.

Comment 7

[Victor Carciu]

Attachment: Video reproducing the issue

Comment 8

[Victor Carciu]

I performed a bisection with following results:

pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3f82bc09a6c61e435354a41ae400a67cf614a975&tochange=ba5fbeb23e744da8a2ba0ffe4420bfb101b4312a

2020-05-20T15:37:19: DEBUG : Found commit message:
Bug 1634031, lazy load appmenu and extension notification panel by using a template r=Gijs

Comment 9

[Rob Wu [:robwu]]

Thanks for the bisect, updating bug flags.

I noticed this bug before when I tried to install an extension on Nightly while in perma-private browsing mode - the doorhanger did not show up.

IMO this is a P1 bug that should be fixed before 78 goes to Beta, but I'll wait until the next triage meeting before assigning severity.

Comment 10

[Emma Malysz]

Attachment: Bug 1636994, ensure panel is created before showing addon install notification

Comment 11

[Shane Caraveo (:mixedpuppy)]

Given it doesn't prevent install, I wouldn't put it to S1. Given there is a patch, P1.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cd8944abc66
ensure panel is created before showing addon install notification r=Gijs,robwu

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6cd8944abc66

Comment 14

[Victor Carciu]

Verified as fixed in latest Nightly(78.0a1 (2020-05-27) ) on Win10x64 and MacOS 10.15.4