Closed
Bug 1636995
Opened 5 years ago
Closed 5 years ago
Uncaught exception message can make the console output out of scroll
Categories
(DevTools :: Console, defect, P1)
DevTools
Console
Tracking
(firefox-esr68 unaffected, firefox76 unaffected, firefox77 unaffected, firefox78 fixed)
RESOLVED
FIXED
Firefox 78
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox76 | --- | unaffected |
| firefox77 | --- | unaffected |
| firefox78 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Because we now render the stacktrace of thrown object, and given the stacktrace is rendered async, it might happen that we don't keep scrolling to bottom.
The solution should be fairly simple, as we already have a mechanism to handle that for console api messages.
|
Assignee | |
Comment 1•5 years ago
|
||
The PageError component wasn't passing the maybeScrollToBottom
prop to the GripMessageBody, which was making the console out-of-autoscroll
since the stacktrace is rendered asynchronously.
Some tests cases are added (throwing directly from an evaluation,
or in a setTimeout), so we cover different paths.
|
||
Comment 2•5 years ago
|
||
Set release status flags based on info from the regressing bug 1595046
status-firefox76:
--- → unaffected
status-firefox77:
--- → unaffected
status-firefox78:
--- → affected
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1e8a2272911
Fix scrolling issue with error messages. r=Honza.
|
|
||
Updated•5 years ago
|
Keywords: regression
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
|
||
Updated•4 years ago
|
status-firefox-esr68:
--- → unaffected
|
||
Updated•4 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•