Closed Bug 1637085 Opened 2 months ago Closed 29 days ago

Use async shutdown rather than nested event loops in ContentParent

Categories

(Core :: DOM: Content Processes, task)

task

Tracking

()

RESOLVED FIXED
mozilla79
Fission Milestone M6a
Tracking Status
firefox79 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

ContentParent registers a separate process shutdown observer for each ContentParent, each of which tells the ContentParent to shut down, and then spins a nested event loop until it finishes. Aside from the fact that nested event loops are generally problematic, this has its own shutdown performance implications. What we really want is to tell all ContentParents to shutdown, and then block our shutdown phase until they all finish. That is what AsyncShutdown does for us by default.

Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9bedd57840ed
Use AsyncShutdown for ContentParent shutdown. r=nika
Fission Milestone: --- → M6a

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kmag, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(kmaglione+bmo)
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8f1051f12365
Use AsyncShutdown for ContentParent shutdown. r=nika
Depends on: 1642491
Flags: needinfo?(kmaglione+bmo)
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/925f89a10fc8
Use AsyncShutdown for ContentParent shutdown. r=nika
Status: NEW → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.