1637085 - Use async shutdown rather than nested event loops in ContentParent

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Kris Maglione [:kmag]]

ContentParent registers a separate process shutdown observer for each ContentParent, each of which tells the ContentParent to shut down, and then spins a nested event loop until it finishes. Aside from the fact that nested event loops are generally problematic, this has its own shutdown performance implications. What we really want is to tell all ContentParents to shutdown, and then block our shutdown phase until they all finish. That is what AsyncShutdown does for us by default.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1637085: Use AsyncShutdown for ContentParent shutdown. r=nika

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bedd57840ed
Use AsyncShutdown for ContentParent shutdown. r=nika

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset 9bedd57840ed (bug 1637085) for WPT failures. CLOSED TREE

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302374212&repo=autoland&lineNumber=3307

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302369230&repo=autoland&lineNumber=4116

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302369233&repo=autoland&lineNumber=4117

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=9bedd57840edbba0a91f41e8347a6a724473d13a

Backout:
https://hg.mozilla.org/integration/autoland/rev/31e3dab240a28c162943acad26fb543c54144dc0

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kmag, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f1051f12365
Use AsyncShutdown for ContentParent shutdown. r=nika

Comment 6

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=b8_aYSJsSVKi3TlEZCL3hQ-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Ctsan%2Cbuild-linux64-tsan%2Fopt%2C%28bo%29&revision=8f1051f12365af7ad7c2a0dd1837e5960d88c8cc

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304581353&repo=autoland&lineNumber=61464
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304588832&repo=autoland&lineNumber=350

Backout: https://hg.mozilla.org/integration/autoland/rev/451b7934feb47bb748041cde53273afc5a567367

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/925f89a10fc8
Use AsyncShutdown for ContentParent shutdown. r=nika

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/925f89a10fc8